Bug 35936

Summary: Cannot save existing report with incorrect AV category
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ReportsAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, lucas
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03
Circulation function:
Bug Depends on: 33966    
Bug Blocks:    
Attachments: Bug 35936: Fix saving existing report with incorrect AV category

Description Jonathan Druart 2024-01-30 09:04:41 UTC
When an existing report is saved and an incorrect AV category is selected, the UI is asking "do you want to save anyway", but the "Update SQL" button leads to a blank page and the report is not saved.
Comment 1 Jonathan Druart 2024-01-30 09:06:17 UTC
Created attachment 161626 [details] [review]
Bug 35936: Fix saving existing report with incorrect AV category

When an existing report is saved and an incorrect AV category is selected,
the UI is asking "do you want to save anyway", but the "Update SQL" button
leads to a blank page and the report is not saved.

On bug 33966 the value is been adjust to 'update_sql' but this incorrect
was left.

To test you need to use the browser inspector to adjust the value of the
selected option.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 2 Jonathan Druart 2024-01-30 09:06:34 UTC
Trivial, skipping SO and QA.
Comment 4 Katrin Fischer 2024-01-30 16:44:38 UTC
Sorry, wrong bug!
Comment 5 Katrin Fischer 2024-01-30 16:50:19 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-02-01 16:23:44 UTC
Pushed to 23.11.x for 23.11.03