Bug 35949

Summary: Useless code pointing to branchreserves.pl in request.tt
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ReportsAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to oldstable --- QA Contact: Emily Lamancusa <emily.lamancusa>
Severity: normal    
Priority: P5 - low CC: emily.lamancusa, fridolin.somers, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10
Circulation function:
Attachments: Bug 35949: Remove useless code pointing to branchreserves.pl in request.tt
Bug 35949: Remove useless code pointing to branchreserves.pl in request.tt
Bug 35949: Remove useless code pointing to branchreserves.pl in request.tt

Description Jonathan Druart 2024-01-30 15:39:53 UTC
171             [% IF ( messagetransfert ) %]
 172                 <div class="dialog message">
 173                     <h2>Hold found for ([% nextreservtitle | html %]), please transfer</h2>
 174                     <p>Hold placed by : <strong> [% nextreservsurname | html %] [% nextreservfirstname | html %]</strong> at : <strong> [% branchname | html %] </strong>, Please transfer this item.
 175                     </p>
 176                     <form name="cancelReservewithtransfert" action="branchreserves.pl" method="post">
 177                         [% INCLUDE 'csrf-token.inc' %]
 178                         <input type="submit" class="button" />
 179                     </form>
 180                 </div>
 181             [% END %]


messagetransfert is never set (it is from circ/waitingreserves.pl, `git grep messagetransfert`) and branchreserves.pl does not exist!
Comment 1 Jonathan Druart 2024-01-30 15:40:55 UTC
Created attachment 161647 [details] [review]
Bug 35949: Remove useless code pointing to branchreserves.pl in request.tt

messagetransfert is never set (it is from circ/waitingreserves.pl, `git grep messagetransfert`) and branchreserves.pl does not exist!
Comment 2 Lucas Gass 2024-01-31 16:19:34 UTC
Created attachment 161697 [details] [review]
Bug 35949: Remove useless code pointing to branchreserves.pl in request.tt

messagetransfert is never set (it is from circ/waitingreserves.pl, `git grep messagetransfert`) and branchreserves.pl does not exist!

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Emily Lamancusa 2024-02-07 20:46:45 UTC
Created attachment 161848 [details] [review]
Bug 35949: Remove useless code pointing to branchreserves.pl in request.tt

messagetransfert is never set (it is from circ/waitingreserves.pl, `git grep messagetransfert`) and branchreserves.pl does not exist!

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Jonathan Druart 2024-03-01 13:18:26 UTC
Pushed to master for 24.05.00.
Comment 5 Fridolin Somers 2024-03-11 08:41:29 UTC
Pushed to 23.11.x for 23.11.04
Comment 6 Lucas Gass 2024-03-19 14:59:16 UTC
Backported to 23.05.x for upcoming 23.05.10