Bug 35949 - Useless code pointing to branchreserves.pl in request.tt
Summary: Useless code pointing to branchreserves.pl in request.tt
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-30 15:39 UTC by Jonathan Druart
Modified: 2024-02-07 20:48 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35949: Remove useless code pointing to branchreserves.pl in request.tt (1.71 KB, patch)
2024-01-30 15:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35949: Remove useless code pointing to branchreserves.pl in request.tt (1.77 KB, patch)
2024-01-31 16:19 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35949: Remove useless code pointing to branchreserves.pl in request.tt (1.84 KB, patch)
2024-02-07 20:46 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-01-30 15:39:53 UTC
171             [% IF ( messagetransfert ) %]
 172                 <div class="dialog message">
 173                     <h2>Hold found for ([% nextreservtitle | html %]), please transfer</h2>
 174                     <p>Hold placed by : <strong> [% nextreservsurname | html %] [% nextreservfirstname | html %]</strong> at : <strong> [% branchname | html %] </strong>, Please transfer this item.
 175                     </p>
 176                     <form name="cancelReservewithtransfert" action="branchreserves.pl" method="post">
 177                         [% INCLUDE 'csrf-token.inc' %]
 178                         <input type="submit" class="button" />
 179                     </form>
 180                 </div>
 181             [% END %]


messagetransfert is never set (it is from circ/waitingreserves.pl, `git grep messagetransfert`) and branchreserves.pl does not exist!
Comment 1 Jonathan Druart 2024-01-30 15:40:55 UTC
Created attachment 161647 [details] [review]
Bug 35949: Remove useless code pointing to branchreserves.pl in request.tt

messagetransfert is never set (it is from circ/waitingreserves.pl, `git grep messagetransfert`) and branchreserves.pl does not exist!
Comment 2 Lucas Gass 2024-01-31 16:19:34 UTC
Created attachment 161697 [details] [review]
Bug 35949: Remove useless code pointing to branchreserves.pl in request.tt

messagetransfert is never set (it is from circ/waitingreserves.pl, `git grep messagetransfert`) and branchreserves.pl does not exist!

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Emily Lamancusa 2024-02-07 20:46:45 UTC
Created attachment 161848 [details] [review]
Bug 35949: Remove useless code pointing to branchreserves.pl in request.tt

messagetransfert is never set (it is from circ/waitingreserves.pl, `git grep messagetransfert`) and branchreserves.pl does not exist!

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>