Bug 35983

Summary: Library specific refund lost item replacement fee cannot be 'refund_unpaid'
Product: Koha Reporter: Lucas Gass <lucas>
Component: CirculationAssignee: Lucas Gass <lucas>
Status: Pushed to oldstable --- QA Contact: Emily Lamancusa <emily.lamancusa>
Severity: normal    
Priority: P5 - low CC: emily.lamancusa, fridolin.somers, gmcharlt, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10
Attachments: Bug 35983: Remove extra seleted=selected from dropdown menu
Bug 35983: Remove extra seleted=selected from dropdown menu
Bug 35983: Remove extra seleted=selected from dropdown menu

Description Lucas Gass 2024-02-02 00:02:45 UTC
To recreate:
1. Admin > Circ & fine rules 
2. Select a library at the top of the forms ( #selectlibrary )
3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)".
4. Press save and let the page reload.
5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine".
Comment 1 Lucas Gass 2024-02-02 00:06:01 UTC
Created attachment 161719 [details] [review]
Bug 35983: Remove extra seleted=selected from dropdown menu

To test:
1. Admin > Circ & fine rules
2. Select a library at the top of the forms ( #selectlibrary )
3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)".
4. Press save and let the page reload.
5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine".
6. APPLY PATCH
7. Try steps 2 - 5 again but this time the value in the dropdown should not change.
Comment 2 David Nind 2024-02-07 22:24:46 UTC
Created attachment 161858 [details] [review]
Bug 35983: Remove extra seleted=selected from dropdown menu

To test:
1. Admin > Circ & fine rules
2. Select a library at the top of the forms ( #selectlibrary )
3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)".
4. Press save and let the page reload.
5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine".
6. APPLY PATCH
7. Try steps 2 - 5 again but this time the value in the dropdown should not change.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Emily Lamancusa 2024-02-20 15:20:12 UTC
Created attachment 162299 [details] [review]
Bug 35983: Remove extra seleted=selected from dropdown menu

To test:
1. Admin > Circ & fine rules
2. Select a library at the top of the forms ( #selectlibrary )
3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)".
4. Press save and let the page reload.
5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine".
6. APPLY PATCH
7. Try steps 2 - 5 again but this time the value in the dropdown should not change.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Emily Lamancusa 2024-02-20 15:20:46 UTC
Good catch - thanks for the fix! Passing QA
Comment 5 Katrin Fischer 2024-03-08 17:59:38 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-03-11 14:34:28 UTC
Pushed to 23.11.x for 23.11.04
Comment 7 Lucas Gass 2024-03-19 21:20:10 UTC
Backported to 23.05.x for upcoming 23.05.10