Bug 35983 - Library specific refund lost item replacement fee cannot be 'refund_unpaid'
Summary: Library specific refund lost item replacement fee cannot be 'refund_unpaid'
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-02 00:02 UTC by Lucas Gass (lukeg)
Modified: 2024-03-19 21:20 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10
Circulation function:

Attachments
Bug 35983: Remove extra seleted=selected from dropdown menu (2.06 KB, patch)
2024-02-02 00:06 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 35983: Remove extra seleted=selected from dropdown menu (2.10 KB, patch)
2024-02-07 22:24 UTC, David Nind 		Details | Diff | Splinter Review
Bug 35983: Remove extra seleted=selected from dropdown menu (2.17 KB, patch)
2024-02-20 15:20 UTC, Emily Lamancusa (emlam) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-02-02 00:02:45 UTC 
To recreate:
1. Admin > Circ & fine rules 
2. Select a library at the top of the forms ( #selectlibrary )
3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)".
4. Press save and let the page reload.
5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine".
Comment 1 Lucas Gass (lukeg) 2024-02-02 00:06:01 UTC 
Created attachment 161719 [details] [review]
Bug 35983: Remove extra seleted=selected from dropdown menu

To test:
1. Admin > Circ & fine rules
2. Select a library at the top of the forms ( #selectlibrary )
3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)".
4. Press save and let the page reload.
5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine".
6. APPLY PATCH
7. Try steps 2 - 5 again but this time the value in the dropdown should not change.
Comment 2 David Nind 2024-02-07 22:24:46 UTC 
Created attachment 161858 [details] [review]
Bug 35983: Remove extra seleted=selected from dropdown menu

To test:
1. Admin > Circ & fine rules
2. Select a library at the top of the forms ( #selectlibrary )
3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)".
4. Press save and let the page reload.
5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine".
6. APPLY PATCH
7. Try steps 2 - 5 again but this time the value in the dropdown should not change.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Emily Lamancusa (emlam) 2024-02-20 15:20:12 UTC 
Created attachment 162299 [details] [review]
Bug 35983: Remove extra seleted=selected from dropdown menu

To test:
1. Admin > Circ & fine rules
2. Select a library at the top of the forms ( #selectlibrary )
3. Try to change the 'Refund lost item replacement fee' to "Refund lost item charge (only if unpaid)".
4. Press save and let the page reload.
5. Look at the dropdown again, the value is now set to "Refund lost item charge and restore overdue fine".
6. APPLY PATCH
7. Try steps 2 - 5 again but this time the value in the dropdown should not change.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Emily Lamancusa (emlam) 2024-02-20 15:20:46 UTC 
Good catch - thanks for the fix! Passing QA
Comment 5 Katrin Fischer 2024-03-08 17:59:38 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-03-11 14:34:28 UTC 
Pushed to 23.11.x for 23.11.04
Comment 7 Lucas Gass (lukeg) 2024-03-19 21:20:10 UTC 
Backported to 23.05.x for upcoming 23.05.10