Bug 35985

Summary: ./t/db_dependent/check_sysprefs.t --showsql since Bug 34979
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: Installation and upgrade (command-line installer)Assignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 34979    
Bug Blocks:    

Description Fridolin Somers 2024-02-02 08:21:20 UTC
With Bug 34979 looks like we need to adapt ./t/db_dependent/check_sysprefs.t --showsql

Example :
kohadev-koha@kohadevbox:koha(master)$ ./t/db_dependent/check_sysprefs.t --showsql
1..2
# Subtest: Compare database with sysprefs.sql file
('MARCOrgCode','OSt','','Define MARC Organization Code for MARC21 records - http://www.loc.gov/marc/organizations/orgshome.html','free'),
    1..0
    # No tests run!
not ok 1 - No tests run for subtest "Compare database with sysprefs.sql file"
#   Failed test 'No tests run for subtest "Compare database with sysprefs.sql file"'
#   at ./t/db_dependent/check_sysprefs.t line 53.
# Subtest: Compare sysprefs.sql with YAML files
    1..2
    ok 1 - No system preference entries missing from sysprefs.sql
    ok 2 - No system preference entries missing from YAML files
ok 2 - Compare sysprefs.sql with YAML files
# Looks like you failed 1 test of 2.

Too much verbose.

Should we skip subtest "Compare database with sysprefs.sql file" ?
Comment 1 Katrin Fischer 2024-02-02 08:37:28 UTC
I wrote the patch, but the different comparisons are confusing :( Happy to have some help with the fix really. I think the --showsql is to help fix an already found problem, so it probably makes sense to skip tests when the script is run with this parameter.