With Bug 34979 looks like we need to adapt ./t/db_dependent/check_sysprefs.t --showsql Example : kohadev-koha@kohadevbox:koha(master)$ ./t/db_dependent/check_sysprefs.t --showsql 1..2 # Subtest: Compare database with sysprefs.sql file ('MARCOrgCode','OSt','','Define MARC Organization Code for MARC21 records - http://www.loc.gov/marc/organizations/orgshome.html','free'), 1..0 # No tests run! not ok 1 - No tests run for subtest "Compare database with sysprefs.sql file" # Failed test 'No tests run for subtest "Compare database with sysprefs.sql file"' # at ./t/db_dependent/check_sysprefs.t line 53. # Subtest: Compare sysprefs.sql with YAML files 1..2 ok 1 - No system preference entries missing from sysprefs.sql ok 2 - No system preference entries missing from YAML files ok 2 - Compare sysprefs.sql with YAML files # Looks like you failed 1 test of 2. Too much verbose. Should we skip subtest "Compare database with sysprefs.sql file" ?
I wrote the patch, but the different comparisons are confusing :( Happy to have some help with the fix really. I think the --showsql is to help fix an already found problem, so it probably makes sense to skip tests when the script is run with this parameter.