Summary: | Dead code in tags/review | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.05.00
|
Circulation function: | |
Bug Depends on: | 20489 | ||
Bug Blocks: | 34478 | ||
Attachments: |
Bug 36019: Remove dead code in tags/review
Bug 36019: Remove dead code in tags/review |
Description
Jonathan Druart
2024-02-07 14:54:11 UTC
Created attachment 161811 [details] [review] Bug 36019: Remove dead code in tags/review Since bug 20489 it is no longer possible to login with the DB user. At the time, get_template_and_user returned borrowernumber=0 in this case. In tags/review.pl we have: $borrowernumber == 0 and push @errors, {op_zero=>1}; This condition is never met, and op_zero related code can be removed in the template. Test plan: Confirm the above Created attachment 161817 [details] [review] Bug 36019: Remove dead code in tags/review Since bug 20489 it is no longer possible to login with the DB user. At the time, get_template_and_user returned borrowernumber=0 in this case. In tags/review.pl we have: $borrowernumber == 0 and push @errors, {op_zero=>1}; This condition is never met, and op_zero related code can be removed in the template. Test plan: Confirm the above Signed-off-by: Owen Leonard <oleonard@myacpl.org> Pushed to master for 24.05.00. Enhancement not pushed to 23.11.x |