Bug 36019 - Dead code in tags/review
Summary: Dead code in tags/review
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 20489
Blocks: 34478
  Show dependency tree / graph
 
Reported: 2024-02-07 14:54 UTC by Jonathan Druart
Modified: 2024-12-23 08:06 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:

Attachments
Bug 36019: Remove dead code in tags/review (2.38 KB, patch)
2024-02-07 14:56 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 36019: Remove dead code in tags/review (2.43 KB, patch)
2024-02-07 15:44 UTC, Owen Leonard 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-02-07 14:54:11 UTC 
Since bug 20489 it is no longer possible to login with the DB user.
At the time, get_template_and_user returned borrowernumber=0 in this case.

In tags/review.pl we have:
  $borrowernumber == 0 and push @errors, {op_zero=>1};

This condition is never met, and op_zero related code can be removed in the template.
Comment 1 Jonathan Druart 2024-02-07 14:56:14 UTC 
Created attachment 161811 [details] [review]
Bug 36019: Remove dead code in tags/review

Since bug 20489 it is no longer possible to login with the DB user.
At the time, get_template_and_user returned borrowernumber=0 in this case.

In tags/review.pl we have:
  $borrowernumber == 0 and push @errors, {op_zero=>1};

This condition is never met, and op_zero related code can be removed in the template.

Test plan:
Confirm the above
Comment 2 Owen Leonard 2024-02-07 15:44:13 UTC 
Created attachment 161817 [details] [review]
Bug 36019: Remove dead code in tags/review

Since bug 20489 it is no longer possible to login with the DB user.
At the time, get_template_and_user returned borrowernumber=0 in this
case.

In tags/review.pl we have:
  $borrowernumber == 0 and push @errors, {op_zero=>1};

This condition is never met, and op_zero related code can be removed in
the template.

Test plan:
Confirm the above

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2024-03-01 13:18:45 UTC 
Pushed to master for 24.05.00.
Comment 4 Fridolin Somers 2024-03-11 08:44:26 UTC 
Enhancement not pushed to 23.11.x