Summary: | The "Next" pagination button has a double instead of a single angle | ||
---|---|---|---|
Product: | Koha | Reporter: | Raphael Straub <raphael.straub> |
Component: | OPAC | Assignee: | Raphael Straub <raphael.straub> |
Status: | Pushed to stable --- | QA Contact: | Emily Lamancusa <emily.lamancusa> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | barbara.johnson, emily.lamancusa, fridolin.somers, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.05.10
|
|
Bug Depends on: | 5287 | ||
Bug Blocks: | |||
Attachments: |
Bug 36032: Use a single angle in the "Next" button
Bug 36032: Use a single angle in the "Next" button Bug 36032: Use a single angle in the "Next" button |
Description
Raphael Straub
2024-02-08 08:53:24 UTC
Created attachment 161878 [details] [review] Bug 36032: Use a single angle in the "Next" button The "Next" pagination button in the OPAC result list has a double angle whereas the "Previous" button only has a single angle. This patch fixes that error. To test: 1) Do a search in the OPAC with more than one page of results. 2) Observe that the "Next" button has a double angle whereas the "Previous" button has only a single angle. 3) Apply the patch. 4) Repeat steps 1 and 2. 5) Verify that the "Next" button now has a single angle. Sponsored-by: Karlsruhe Institute of Technology (KIT) Created attachment 161927 [details] [review] Bug 36032: Use a single angle in the "Next" button The "Next" pagination button in the OPAC result list has a double angle whereas the "Previous" button only has a single angle. This patch fixes that error. To test: 1) Do a search in the OPAC with more than one page of results. 2) Observe that the "Next" button has a double angle whereas the "Previous" button has only a single angle. 3) Apply the patch. 4) Repeat steps 1 and 2. 5) Verify that the "Next" button now has a single angle. Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Created attachment 162325 [details] [review] Bug 36032: Use a single angle in the "Next" button The "Next" pagination button in the OPAC result list has a double angle whereas the "Previous" button only has a single angle. This patch fixes that error. To test: 1) Do a search in the OPAC with more than one page of results. 2) Observe that the "Next" button has a double angle whereas the "Previous" button has only a single angle. 3) Apply the patch. 4) Repeat steps 1 and 2. 5) Verify that the "Next" button now has a single angle. Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Good catch! Thanks for the fix. Passing QA Pushed for 24.05! Well done everyone, thank you! Looks like there is the same issue in opac-authoritiessearchresultlist.tt : https://git.koha-community.org/Koha-community/Koha/src/commit/5a188651e484517f28367e44183b680fa77ad77b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt#L33 Can you also fix please ? Or open a new report. (In reply to Fridolin Somers from comment #7) > Looks like there is the same issue in opac-authoritiessearchresultlist.tt : > > https://git.koha-community.org/Koha-community/Koha/src/commit/ > 5a188651e484517f28367e44183b680fa77ad77b/koha-tmpl/opac-tmpl/bootstrap/en/ > modules/opac-authoritiessearchresultlist.tt#L33 I already saw this, but I don't know where this is used or if this is used at all. If I search for authorities I get a result list that uses the other pagination bar: https://git.koha-community.org/Koha-community/Koha/src/commit/5a188651e484517f28367e44183b680fa77ad77b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt#L74 Backported to 23.05.x for 23.05.10 |