Bug 36032 - The "Next" pagination button has a double instead of a single angle
Summary: The "Next" pagination button has a double instead of a single angle
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Raphael Straub
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on: 5287
Blocks:
  Show dependency treegraph
 
Reported: 2024-02-08 08:53 UTC by Raphael Straub
Modified: 2024-03-19 20:57 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.05.10


Attachments
Bug 36032: Use a single angle in the "Next" button (2.48 KB, patch)
2024-02-08 09:04 UTC, Raphael Straub
Details | Diff | Splinter Review
Bug 36032: Use a single angle in the "Next" button (2.54 KB, patch)
2024-02-08 14:59 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 36032: Use a single angle in the "Next" button (2.62 KB, patch)
2024-02-21 20:32 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Straub 2024-02-08 08:53:24 UTC
The "Next" pagination button in the OPAC result list has a double angle. It should have a single angle as the "Previous" button.
Comment 1 Raphael Straub 2024-02-08 09:04:13 UTC
Created attachment 161878 [details] [review]
Bug 36032: Use a single angle in the "Next" button

The "Next" pagination button in the OPAC result list has a double angle
whereas the "Previous" button only has a single angle. This patch fixes
that error.

To test:
1) Do a search in the OPAC with more than one page of results.
2) Observe that the "Next" button has a double angle whereas the
   "Previous" button has only a single angle.
3) Apply the patch.
4) Repeat steps 1 and 2.
5) Verify that the "Next" button now has a single angle.

Sponsored-by: Karlsruhe Institute of Technology (KIT)
Comment 2 ByWater Sandboxes 2024-02-08 14:59:50 UTC
Created attachment 161927 [details] [review]
Bug 36032: Use a single angle in the "Next" button

The "Next" pagination button in the OPAC result list has a double angle
whereas the "Previous" button only has a single angle. This patch fixes
that error.

To test:
1) Do a search in the OPAC with more than one page of results.
2) Observe that the "Next" button has a double angle whereas the
   "Previous" button has only a single angle.
3) Apply the patch.
4) Repeat steps 1 and 2.
5) Verify that the "Next" button now has a single angle.

Sponsored-by: Karlsruhe Institute of Technology (KIT)
Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Emily Lamancusa 2024-02-21 20:32:14 UTC
Created attachment 162325 [details] [review]
Bug 36032: Use a single angle in the "Next" button

The "Next" pagination button in the OPAC result list has a double angle
whereas the "Previous" button only has a single angle. This patch fixes
that error.

To test:
1) Do a search in the OPAC with more than one page of results.
2) Observe that the "Next" button has a double angle whereas the
   "Previous" button has only a single angle.
3) Apply the patch.
4) Repeat steps 1 and 2.
5) Verify that the "Next" button now has a single angle.

Sponsored-by: Karlsruhe Institute of Technology (KIT)
Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Emily Lamancusa 2024-02-21 20:32:45 UTC
Good catch! Thanks for the fix. Passing QA
Comment 5 Katrin Fischer 2024-03-08 17:59:50 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-03-11 10:35:57 UTC
Introduced by Bug 5287
Comment 7 Fridolin Somers 2024-03-11 10:40:27 UTC
Looks like there is the same issue in opac-authoritiessearchresultlist.tt :

https://git.koha-community.org/Koha-community/Koha/src/commit/5a188651e484517f28367e44183b680fa77ad77b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt#L33

Can you also fix please ?
Or open a new report.
Comment 8 Raphael Straub 2024-03-11 11:42:03 UTC
(In reply to Fridolin Somers from comment #7)
> Looks like there is the same issue in opac-authoritiessearchresultlist.tt :
> 
> https://git.koha-community.org/Koha-community/Koha/src/commit/
> 5a188651e484517f28367e44183b680fa77ad77b/koha-tmpl/opac-tmpl/bootstrap/en/
> modules/opac-authoritiessearchresultlist.tt#L33

I already saw this, but I don't know where this is used or if this is used at all. If I search for authorities I get a result list that uses the other pagination bar:

https://git.koha-community.org/Koha-community/Koha/src/commit/5a188651e484517f28367e44183b680fa77ad77b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt#L74
Comment 9 Lucas Gass 2024-03-19 20:57:44 UTC
Backported to 23.05.x for 23.05.10