| Summary: | Confusing notice is sent if a hold is cancelled on check-in with no reason specified | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Component: | Hold requests | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 29007 | ||
| Bug Blocks: | |||
|
Description
Emily Lamancusa (emlam)
2024-02-08 15:56:01 UTC
Never mind, this was already fixed by bug 35535...should've tested on master before I reported it. :) *** This bug has been marked as a duplicate of bug 35535 *** Sorry Emily. I sneakily put that fix into Bug 29007. You can also fix this in the meantime with a bit of JS. :) Haha thanks for fixing it! :) Good point - I addressed it locally by adding [%- IF hold.cancellation_reason != 'NULL' -%] to the notice template before I filed the bug, but I appreciate the JS suggestion as well! |