Bug 36050 - Confusing notice is sent if a hold is cancelled on check-in with no reason specified
Summary: Confusing notice is sent if a hold is cancelled on check-in with no reason sp...
Status: RESOLVED DUPLICATE of bug 35535
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Emily Lamancusa (emlam)
QA Contact: Testopia
URL:
Keywords:
Depends on: 29007
Blocks:
  Show dependency tree / graph
 
Reported: 2024-02-08 15:56 UTC by Emily Lamancusa (emlam)
Modified: 2024-02-08 18:38 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa (emlam) 2024-02-08 15:56:01 UTC 
In all other locations where a hold cancellation reason can be specified, no notice is sent if a cancellation reason is not selected. However, if a hold is cancelled from the check-in pop-up and no reason is selected, a notice is sent without a valid reason value. This occurs because the <select> value is set to "NULL", when it should be left undefined.
Comment 1 Emily Lamancusa (emlam) 2024-02-08 16:08:37 UTC 
Never mind, this was already fixed by bug 35535...should've tested on master before I reported it. :)

*** This bug has been marked as a duplicate of bug 35535 ***
Comment 2 Lucas Gass (lukeg) 2024-02-08 18:01:39 UTC 
Sorry Emily. I sneakily put that fix into Bug 29007.

You can also fix this in the meantime with a bit of JS. :)
Comment 3 Emily Lamancusa (emlam) 2024-02-08 18:38:25 UTC 
Haha thanks for fixing it! :)

Good point - I addressed it locally by adding [%- IF hold.cancellation_reason != 'NULL' -%] to the notice template before I filed the bug, but I appreciate the JS suggestion as well!