Bug 36072

Summary: Can request articles even if ArticleRequests is off
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: Pushed to oldoldoldstable --- QA Contact: Martin Renvoize <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: dcook, didier.gautheron, fridolin.somers, jonathan.druart, katrin.fischer, laurent.ducos, lucas, m.de.rooy, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03,23.05.09,22.11.15,22.05.19
Bug Depends on: 14610    
Bug Blocks:    
Attachments: Bug 36072: opac-request-article should check syspref
Bug 36072: opac-request-article should check syspref

Description Jonathan Druart 2024-02-12 15:36:54 UTC
opac/opac-request-article.pl is not testing the syspref.
Comment 1 Marcel de Rooy 2024-02-13 12:38:25 UTC
Created attachment 162106 [details] [review]
Bug 36072: opac-request-article should check syspref

Note: This is handled now just like opac-reserve.

Test plan:
Disable ArticleRequests and hit the page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2024-02-13 12:40:27 UTC
I am not sure that this should be a security report. Is this about DDOS attack on the page, filling the database or so?
Comment 3 Marcel de Rooy 2024-02-13 12:40:45 UTC
Trivial patch, self SO
Comment 4 Martin Renvoize 2024-02-13 16:35:29 UTC
Created attachment 162119 [details] [review]
Bug 36072: opac-request-article should check syspref

Note: This is handled now just like opac-reserve.

Test plan:
Disable ArticleRequests and hit the page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2024-02-13 16:36:00 UTC
Trivlal fix, works, and passes QA scripts.

Passing QA
Comment 6 Martin Renvoize 2024-02-15 09:46:35 UTC
Pushed to master for 24.05.00