|
Description
Kelly McElligott
2024-02-13 14:01:31 UTC
Created attachment 170612 [details] [review] Bug 36083: Fix HTML additional contents for the logged in branchcode This patch updates the calls to AdditionalContents.get() to use Branches.GetLoggedInBranchcode instead of the logged in users homebranch for the library parameter. To test: 1. In Tools > HTML Customizations 2. Choose to create an entry in StaffAcquisitionsHome 3. Assign it to a specific library It's helpful to test with libraries other than Centerville 4. Add text and publication date (important or it will never display) 5. Save 6. Go to the Acquisitions Home page - logged into that library, no text displays. 7. Apply patch and refresh browser 8. Notice the library specifc content displays 9. Notice content created for all libraries still displays too 10. Test HTML content for specific libraries works on all 8 pages IntranetmainUserBlock Staff AcquisitionsHome StaffAuthoritiesHome StaffCataloguing Home StaffListsHome StaffPatronsHome StaffPOSHome StaffSerialsHome Everything works except for StaffAuthoritiesHome Created attachment 170615 [details] [review] Bug 36083: Fix HTML additional contents for the logged in branchcode This patch updates the calls to AdditionalContents.get() to use Branches.GetLoggedInBranchcode instead of the logged in users homebranch for the library parameter. To test: 1. In Tools > HTML Customizations 2. Choose to create an entry in StaffAcquisitionsHome 3. Assign it to a specific library It's helpful to test with libraries other than Centerville 4. Add text and publication date (important or it will never display) 5. Save 6. Go to the Acquisitions Home page - logged into that library, no text displays. 7. Apply patch and refresh browser 8. Notice the library specifc content displays 9. Notice content created for all libraries still displays too 10. Test HTML content for specific libraries works on all 8 pages IntranetmainUserBlock Staff AcquisitionsHome StaffAuthoritiesHome StaffCataloguing Home StaffListsHome StaffPatronsHome StaffPOSHome StaffSerialsHome Created attachment 170616 [details] [review] Bug 36083: (follow-up) add USE Branches for html customizations (In reply to Sam Lau from comment #2) > Everything works except for StaffAuthoritiesHome Good catch. I didn't realize that page didn't include Branches Created attachment 170617 [details] [review] Bug 36083: Fix HTML additional contents for the logged in branchcode This patch updates the calls to AdditionalContents.get() to use Branches.GetLoggedInBranchcode instead of the logged in users homebranch for the library parameter. To test: 1. In Tools > HTML Customizations 2. Choose to create an entry in StaffAcquisitionsHome 3. Assign it to a specific library It's helpful to test with libraries other than Centerville 4. Add text and publication date (important or it will never display) 5. Save 6. Go to the Acquisitions Home page - logged into that library, no text displays. 7. Apply patch and refresh browser 8. Notice the library specifc content displays 9. Notice content created for all libraries still displays too 10. Test HTML content for specific libraries works on all 8 pages IntranetmainUserBlock Staff AcquisitionsHome StaffAuthoritiesHome StaffCataloguing Home StaffListsHome StaffPatronsHome StaffPOSHome StaffSerialsHome Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 170618 [details] [review] Bug 36083: (follow-up) add USE Branches for html customizations Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 171798 [details] [review] Bug 36083: Fix HTML additional contents for the logged in branchcode This patch updates the calls to AdditionalContents.get() to use Branches.GetLoggedInBranchcode instead of the logged in users homebranch for the library parameter. To test: 1. In Tools > HTML Customizations 2. Choose to create an entry in StaffAcquisitionsHome 3. Assign it to a specific library It's helpful to test with libraries other than Centerville 4. Add text and publication date (important or it will never display) 5. Save 6. Go to the Acquisitions Home page - logged into that library, no text displays. 7. Apply patch and refresh browser 8. Notice the library specifc content displays 9. Notice content created for all libraries still displays too 10. Test HTML content for specific libraries works on all 8 pages IntranetmainUserBlock Staff AcquisitionsHome StaffAuthoritiesHome StaffCataloguing Home StaffListsHome StaffPatronsHome StaffPOSHome StaffSerialsHome Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 171799 [details] [review] Bug 36083: (follow-up) add USE Branches for html customizations Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 171800 [details] [review] Bug 36083: Fix HTML additional contents for the logged in branchcode This patch updates the calls to AdditionalContents.get() to use Branches.GetLoggedInBranchcode instead of the logged in users homebranch for the library parameter. To test: 1. In Tools > HTML Customizations 2. Choose to create an entry in StaffAcquisitionsHome 3. Assign it to a specific library It's helpful to test with libraries other than Centerville 4. Add text and publication date (important or it will never display) 5. Save 6. Go to the Acquisitions Home page - logged into that library, no text displays. 7. Apply patch and refresh browser 8. Notice the library specifc content displays 9. Notice content created for all libraries still displays too 10. Test HTML content for specific libraries works on all 8 pages IntranetmainUserBlock Staff AcquisitionsHome StaffAuthoritiesHome StaffCataloguing Home StaffListsHome StaffPatronsHome StaffPOSHome StaffSerialsHome Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 171801 [details] [review] Bug 36083: (follow-up) add USE Branches for html customizations Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Great job here, Brendan! Passing QA! Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Doesn't clean apply to 24.05.x, rebase if needed. |