| Summary: | Remove useless code form opac-account-pay.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | Pushed to oldstable --- | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, lucas, pedro.amorim |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.04,23.05.10
|
|
| Circulation function: | |||
| Bug Depends on: | 23215 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 36088 - Remove useless code form opac-account-pay.pl
Bug 36088 - Remove useless code form opac-account-pay.pl Bug 36088 - Remove useless code form opac-account-pay.pl Bug 36088: Remove useless code form opac-account-pay.pl |
||
|
Description
Kyle M Hall (khall)
2024-02-13 20:04:34 UTC
Created attachment 162128 [details] [review] Bug 36088 - Remove useless code form opac-account-pay.pl The script opac-account-pay.pl sums the selected accountlines, formats the amount, pulls the currently active currency, and does nothing with any of this data. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Note there is no change in behavior Created attachment 162251 [details] [review] Bug 36088 - Remove useless code form opac-account-pay.pl The script opac-account-pay.pl sums the selected accountlines, formats the amount, pulls the currently active currency, and does nothing with any of this data. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Note there is no change in behavior Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. I'm not sure that I've tested this correctly. Do I need to add a payment plugin, such as the paypal one, to test this change? If I haven't tested correctly, please change status back to needs signoff. 2. I added some charges for a patron, and then added a payment and a write off. 3. In the OPAC I made sure that the figures shown in the charges tab add up correctly. Created attachment 162288 [details] [review] Bug 36088 - Remove useless code form opac-account-pay.pl The script opac-account-pay.pl sums the selected accountlines, formats the amount, pulls the currently active currency, and does nothing with any of this data. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Note there is no change in behavior Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 162289 [details] [review] Bug 36088: Remove useless code form opac-account-pay.pl The script opac-account-pay.pl sums the selected accountlines, formats the amount, pulls the currently active currency, and does nothing with any of this data. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Note there is no change in behavior Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> PA amended title (missing 'Bug ####:' Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.04 Backported to 23.05.x for upcoming 23.05.10 |