Bug 36096

Summary: Add ability to select default sort and display length for tables on 'Holds awaiting pickup' page
Product: Koha Reporter: Lucas Gass <lucas>
Component: CirculationAssignee: Lucas Gass <lucas>
Status: Needs documenting --- QA Contact: Martin Renvoize <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt, kyle.m.hall, martin.renvoize, philip.orr
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Bug Depends on: 36592    
Bug Blocks:    
Attachments: Bug 36096: Add ability to set default sort and length to waitingreserves tables
Bug 36096: Add ability to set default sort and length to waitingreserves tables
Bug 36096: Add ability to set default sort and length to waitingreserves tables

Description Lucas Gass 2024-02-14 16:54:48 UTC
There are 3 tables on waitingreserves.pl. ( holdscr | holdso | holdst ) It would be nice if we could set the default sort and display length via Table settings.
Comment 1 Lucas Gass 2024-02-14 16:59:20 UTC
Created attachment 162159 [details] [review]
Bug 36096: Add ability to set default sort and length to waitingreserves tables

To test:
1. APPLY patch and restart services.
2. Have waiting holds, waiting holds past the expiration date, and waiting holds with cancellation requests.
3. Go to Administration -> Table settings and find each of the tables. ( holdscr | holdso | holdst )
4. Each table should now include a 'Default display length:' and 'Default sort order:'
5. Play with those Table settings, ensuring they behave correctly.
Comment 2 Philip Orr 2024-04-12 08:42:29 UTC
The buttons are there, but when I changed the default sort order
for "holdscr" to "title", saving did nothing - it just jumped back
to the default "waiting_since". Same for "holdso" and "holdst".
Comment 3 Lucas Gass 2024-04-12 09:45:43 UTC
(In reply to Philip Orr from comment #2)
> The buttons are there, but when I changed the default sort order
> for "holdscr" to "title", saving did nothing - it just jumped back
> to the default "waiting_since". Same for "holdso" and "holdst".

Thanks Philip! It looks like we have a bug with setting the default sort and display length. 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36592
Comment 4 Owen Leonard 2024-04-12 13:57:19 UTC
Created attachment 164850 [details] [review]
Bug 36096: Add ability to set default sort and length to waitingreserves tables

To test:
1. APPLY patch and restart services.
2. Have waiting holds, waiting holds past the expiration date, and
   waiting holds with cancellation requests.
3. Go to Administration -> Table settings and find each of the tables. (
   holdscr | holdso | holdst )
4. Each table should now include a 'Default display length:' and
   'Default sort order:'
5. Play with those Table settings, ensuring they behave correctly.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Martin Renvoize 2024-05-13 10:29:45 UTC
Created attachment 166627 [details] [review]
Bug 36096: Add ability to set default sort and length to waitingreserves tables

To test:
1. APPLY patch and restart services.
2. Have waiting holds, waiting holds past the expiration date, and
   waiting holds with cancellation requests.
3. Go to Administration -> Table settings and find each of the tables. (
   holdscr | holdso | holdst )
4. Each table should now include a 'Default display length:' and
   'Default sort order:'
5. Play with those Table settings, ensuring they behave correctly.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2024-05-13 10:30:06 UTC
Trivial improvement, no regressions.

Passing QA
Comment 7 Katrin Fischer 2024-05-13 11:50:35 UTC
Please double check - I changed the default from 20 to 50 on the holds waiting for pickup table and it remains preselected at 20. Same for updated sorting, it sticks with waiting date. 

Looking at the first tab of the pickup report.
Comment 8 Lucas Gass 2024-05-14 15:57:19 UTC
(In reply to Katrin Fischer from comment #7)
> Please double check - I changed the default from 20 to 50 on the holds
> waiting for pickup table and it remains preselected at 20. Same for updated
> sorting, it sticks with waiting date. 
> 
> Looking at the first tab of the pickup report.

I can't recreate this. Are you picking the right tables in Table settings? 

holdscr - Holds with cancellation requests
holdso - Holds over...
holdst - Holds awaiting pickup 

These table ID's do cause a bit of confusion.
Comment 9 Martin Renvoize 2024-05-15 07:01:44 UTC
Indeed.. it's working for me too.. though you did have me questioning myself.. I thought it might be a disparity between 'GetColumns' and 'GetTableSettings'.. but it is indeed the later consistently already for these tables.
Comment 10 Katrin Fischer 2024-05-16 07:20:58 UTC
I'll double check as soon as I can.
Comment 11 Katrin Fischer 2024-05-17 08:24:35 UTC
I will admit... pushing this and trusting you guys. Please don't disappoint :)
Comment 12 Katrin Fischer 2024-05-17 08:37:26 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 13 Fridolin Somers 2024-05-29 13:21:01 UTC
Depends on Bug 36592 not in 23.11.x