There are 3 tables on waitingreserves.pl. ( holdscr | holdso | holdst ) It would be nice if we could set the default sort and display length via Table settings.
Created attachment 162159 [details] [review] Bug 36096: Add ability to set default sort and length to waitingreserves tables To test: 1. APPLY patch and restart services. 2. Have waiting holds, waiting holds past the expiration date, and waiting holds with cancellation requests. 3. Go to Administration -> Table settings and find each of the tables. ( holdscr | holdso | holdst ) 4. Each table should now include a 'Default display length:' and 'Default sort order:' 5. Play with those Table settings, ensuring they behave correctly.
The buttons are there, but when I changed the default sort order for "holdscr" to "title", saving did nothing - it just jumped back to the default "waiting_since". Same for "holdso" and "holdst".
(In reply to Philip Orr from comment #2) > The buttons are there, but when I changed the default sort order > for "holdscr" to "title", saving did nothing - it just jumped back > to the default "waiting_since". Same for "holdso" and "holdst". Thanks Philip! It looks like we have a bug with setting the default sort and display length. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36592
Created attachment 164850 [details] [review] Bug 36096: Add ability to set default sort and length to waitingreserves tables To test: 1. APPLY patch and restart services. 2. Have waiting holds, waiting holds past the expiration date, and waiting holds with cancellation requests. 3. Go to Administration -> Table settings and find each of the tables. ( holdscr | holdso | holdst ) 4. Each table should now include a 'Default display length:' and 'Default sort order:' 5. Play with those Table settings, ensuring they behave correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 166627 [details] [review] Bug 36096: Add ability to set default sort and length to waitingreserves tables To test: 1. APPLY patch and restart services. 2. Have waiting holds, waiting holds past the expiration date, and waiting holds with cancellation requests. 3. Go to Administration -> Table settings and find each of the tables. ( holdscr | holdso | holdst ) 4. Each table should now include a 'Default display length:' and 'Default sort order:' 5. Play with those Table settings, ensuring they behave correctly. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial improvement, no regressions. Passing QA
Please double check - I changed the default from 20 to 50 on the holds waiting for pickup table and it remains preselected at 20. Same for updated sorting, it sticks with waiting date. Looking at the first tab of the pickup report.
(In reply to Katrin Fischer from comment #7) > Please double check - I changed the default from 20 to 50 on the holds > waiting for pickup table and it remains preselected at 20. Same for updated > sorting, it sticks with waiting date. > > Looking at the first tab of the pickup report. I can't recreate this. Are you picking the right tables in Table settings? holdscr - Holds with cancellation requests holdso - Holds over... holdst - Holds awaiting pickup These table ID's do cause a bit of confusion.
Indeed.. it's working for me too.. though you did have me questioning myself.. I thought it might be a disparity between 'GetColumns' and 'GetTableSettings'.. but it is indeed the later consistently already for these tables.
I'll double check as soon as I can.
I will admit... pushing this and trusting you guys. Please don't disappoint :)
Pushed for 24.05! Well done everyone, thank you!
Depends on Bug 36592 not in 23.11.x