Summary: | Port default HOLD notice to Template Toolkit syntax | ||
---|---|---|---|
Product: | Koha | Reporter: | Emily Lamancusa (emlam) <emily.lamancusa> |
Component: | Notices | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
Status: | Needs documenting --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | Main | Keywords: | Academy, roadmap_24_05 |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
The default notice template for hold pickup notifications now uses modern Template Toolkit rather than the old custom syntax. This will only affect new installations, unless the library chooses to reset their notices to the default.
|
Version(s) released in: |
24.05.00
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 15278 | ||
Attachments: |
Bug 36126: Adjust default HOLD notices to use TT
Bug 36126: Adjust default HOLD notices to use TT |
Description
Emily Lamancusa (emlam)
2024-02-16 21:55:47 UTC
Created attachment 165808 [details] [review] Bug 36126: Adjust default HOLD notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Hold filled: - Check SMS - Check Email - Leave Digests only unchecked 5. Leave SMS number and all email address fields blank for that patron 6. Place a hold for that patron 7. Check in an item to fill the hold 8. Open the Notices tab on that patron's account --> The patron should have a Print "hold filled" notice, since they don't have an email address or SMS number in the system 9. Add a Primary email and SMS number to the patron account 10. Place another hold for that patron 11. Check in an item to fill the hold 12. Go back to the Notices tab on that patron's account --> The patron should now have Email and SMS "hold filled" notices as well 13. Open each notice and confirm that all information is correct Created attachment 166412 [details] [review] Bug 36126: Adjust default HOLD notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Hold filled: - Check SMS - Check Email - Leave Digests only unchecked 5. Leave SMS number and all email address fields blank for that patron 6. Place a hold for that patron 7. Check in an item to fill the hold 8. Open the Notices tab on that patron's account --> The patron should have a Print "hold filled" notice, since they don't have an email address or SMS number in the system 9. Add a Primary email and SMS number to the patron account 10. Place another hold for that patron 11. Check in an item to fill the hold 12. Go back to the Notices tab on that patron's account --> The patron should now have Email and SMS "hold filled" notices as well 13. Open each notice and confirm that all information is correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Simple and clear patch, works in testing. Passing QA Pushed for 24.05! Well done everyone, thank you! Not backported to 23.11.x |