Bug 36126 - Port default HOLD notice to Template Toolkit syntax
Summary: Port default HOLD notice to Template Toolkit syntax
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Emily Lamancusa (emlam)
QA Contact: Testopia
URL:
Keywords: Academy, roadmap_24_05
Depends on:
Blocks: 15278
  Show dependency tree / graph
 
Reported: 2024-02-16 21:55 UTC by Emily Lamancusa (emlam)
Modified: 2024-11-08 14:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
The default notice template for hold pickup notifications now uses modern Template Toolkit rather than the old custom syntax. This will only affect new installations, unless the library chooses to reset their notices to the default.
Version(s) released in:
24.05.00
Circulation function:

Attachments
Bug 36126: Adjust default HOLD notices to use TT (5.28 KB, patch)
2024-04-29 20:55 UTC, Emily Lamancusa (emlam) 		Details | Diff | Splinter Review
Bug 36126: Adjust default HOLD notices to use TT (5.35 KB, patch)
2024-05-08 13:17 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa (emlam) 2024-02-16 21:55:47 UTC 
We have default HOLD notices defined for email, sms, and print - all three need to be updated to Template Toolkit syntax
Comment 1 Emily Lamancusa (emlam) 2024-04-29 20:55:29 UTC 
Created attachment 165808 [details] [review]
Bug 36126: Adjust default HOLD notices to use TT

To test:
1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Enable SMS Notices
    a) Find the system preference SMSSendDriver
    b) Enter "Email" as the value for SMSSendDriver and save
4. Go to a patron account, and set the following messaging preferences:
    Hold filled:
        - Check SMS
        - Check Email
        - Leave Digests only unchecked
5. Leave SMS number and all email address fields blank for that patron
6. Place a hold for that patron
7. Check in an item to fill the hold
8. Open the Notices tab on that patron's account
--> The patron should have a Print "hold filled" notice, since they
don't have an email address or SMS number in the system
9. Add a Primary email and SMS number to the patron account
10. Place another hold for that patron
11. Check in an item to fill the hold
12. Go back to the Notices tab on that patron's account
--> The patron should now have Email and SMS "hold filled" notices as well
13. Open each notice and confirm that all information is correct
Comment 2 Martin Renvoize (ashimema) 2024-05-08 13:17:37 UTC 
Created attachment 166412 [details] [review]
Bug 36126: Adjust default HOLD notices to use TT

To test:
1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Enable SMS Notices
    a) Find the system preference SMSSendDriver
    b) Enter "Email" as the value for SMSSendDriver and save
4. Go to a patron account, and set the following messaging preferences:
    Hold filled:
        - Check SMS
        - Check Email
        - Leave Digests only unchecked
5. Leave SMS number and all email address fields blank for that patron
6. Place a hold for that patron
7. Check in an item to fill the hold
8. Open the Notices tab on that patron's account
--> The patron should have a Print "hold filled" notice, since they
don't have an email address or SMS number in the system
9. Add a Primary email and SMS number to the patron account
10. Place another hold for that patron
11. Check in an item to fill the hold
12. Go back to the Notices tab on that patron's account
--> The patron should now have Email and SMS "hold filled" notices as well
13. Open each notice and confirm that all information is correct

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize (ashimema) 2024-05-08 13:17:59 UTC 
Simple and clear patch, works in testing.

Passing QA
Comment 4 Katrin Fischer 2024-05-10 13:20:12 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-05-29 08:46:54 UTC 
Not backported to 23.11.x