Summary: | Allow users to delete multiple patron lists at once on any page | ||
---|---|---|---|
Product: | Koha | Reporter: | Phan Tung Bui <phan-tung.bui> |
Component: | Tools | Assignee: | Phan Tung Bui <phan-tung.bui> |
Status: | RESOLVED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, david, fridolin.somers, hammat.wele, jesse, lucas, martin.renvoize, phan-tung.bui, philippe.blouin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes patron lists so that when there are more than 20 lists, the lists on the next pages can be deleted. Previously, you were only able to delete the lists on the first page.
|
|
Version(s) released in: |
24.11.00,24.05.06,23.11.11
|
Circulation function: | |
Attachments: |
Bug 36132: Allow to delete multiple patron lists on any page
Bug 36132: Allow to delete multiple patron lists on any page Bug 36132: Allow to delete multiple patron lists on any page Bug 36132: Allow to delete multiple patron lists on any page Bug 36132: Allow to delete multiple patron lists on any page Bug 36132: Allow to delete multiple patron lists on any page |
Description
Phan Tung Bui
2024-02-19 18:39:40 UTC
Created attachment 162283 [details] [review] Bug 36132: Allow to delete multiple patron lists on any page Plan test : 1. Apply the patch. 2. Create at least 22 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete on the 2nd page 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Created attachment 165486 [details] [review] Bug 36132: Allow to delete multiple patron lists on any page Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 169223 [details] [review] Bug 36132: Allow to delete multiple patron lists on any page Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> This one doesn't look correct to me: [% USE raw %] [% USE Asset %] -[% PROCESS 'i18n.inc' %] [% SET footerjs = 1 %] [% INCLUDE 'doc-head-open.inc' %] -<title>[% FILTER collapse %] - [% t("Patron lists") | html %] › - [% t("Tools") | html %] › - [% t("Koha") | html %] -[% END %]</title> +<title>Patron lists › Tools › Koha</title> [% INCLUDE 'doc-head-close.inc' %] [% INCLUDE 'greybox.inc' %] </head> @@ -32,7 +27,6 @@ <div class="row"> <div class="col-sm-10 col-sm-push-2"> <main> - [% INCLUDE 'messages.inc' %] These undoes other changes, like the re-working of the breadcrumbs. Please also check the other removals carefully. Also this appears unrelated to what this patch advertises: - <h1>Patron lists</h1> + <h1>Your patron lists </h1> Please check if this is correct, patron lists can now be shared, so this might also be undoing another intentional change. To hopefully avoid confusion: I had forgotten to remove this from my branch after testing and it was accidentally pushed. Reverted now waiting for a clean patch. Created attachment 170237 [details] [review] Bug 36132: Allow to delete multiple patron lists on any page Plan test : 1. Apply the patch. 2. Create at least 22 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete on the 2nd page 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Created attachment 170699 [details] [review] Bug 36132: Allow to delete multiple patron lists on any page Plan test : 1. Apply the patch. 2. Create at least 22 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete on the 2nd page 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Signed-off-by: David Nind <david@davidnind.com> Created attachment 174548 [details] [review] Bug 36132: Allow to delete multiple patron lists on any page Plan test : 1. Apply the patch. 2. Create at least 22 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete on the 2nd page 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.11! Well done everyone, thank you! BAckported to 24.05.x for upcoming 24.05.06 Pushed to 23.11.x for 23.11.11 Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. |