Summary: | Wrong for attribute on Invoice number: label in invoice.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Accessibility | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, matt.blenkinsop, mkstephens, oleonard, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.05.00,23.11.04,23.05.10
|
Circulation function: | |
Attachments: |
Bug 36140: Correct label for attribute invoice.tt
Bug 36140: Correct label for attribute invoice.tt Bug 36140: Correct label for attribute invoice.tt |
Description
Lucas Gass (lukeg)
2024-02-20 23:17:54 UTC
Created attachment 162311 [details] [review] Bug 36140: Correct label for attribute invoice.tt To test: 1. Go to /cgi-bin/koha/acqui/invoice.pl?invoiceid=X where X is the invoice number. 2. Look at the Invoice number with your dev tools, the for attribute is wrong. ( shippingdate ) 3. Apply patch and look again, the attribute should correctly be invoicenumber. Alternatively, just look at the diff of this trivial change. :) Followed test plan as outlined. Confirmed <label for="shipmentdate">Invoice number:</label> in html when viewing an invoice. Applied patch in Koha Testing Docker. Restarted Apache. Cleared browser cached files. Navigated to invoice and inspected page. Still seeing <label for="shipmentdate">Invoice number:</label>. Created attachment 162518 [details] [review] Bug 36140: Correct label for attribute invoice.tt To test: 1. Go to /cgi-bin/koha/acqui/invoice.pl?invoiceid=X where X is the invoice number. 2. Look at the Invoice number with your dev tools, the for attribute is wrong. ( shippingdate ) 3. Apply patch and look again, the attribute should correctly be invoicenumber. Alternatively, just look at the diff of this trivial change. :) Created attachment 162589 [details] [review] Bug 36140: Correct label for attribute invoice.tt To test: 1. Go to /cgi-bin/koha/acqui/invoice.pl?invoiceid=X where X is the invoice number. 2. Look at the Invoice number with your dev tools, the for attribute is wrong. ( shippingdate ) 3. Apply patch and look again, the attribute should correctly be invoicenumber. Alternatively, just look at the diff of this trivial change. :) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Obvious correction of a copy/paste. Works as intended.. Straight to PQA. Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.04 Backported to 23.05.x for upcoming 23.05.10 Not backporting to 22.11 unless requested |