Bug 36140

Summary: Wrong for attribute on Invoice number: label in invoice.tt
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: AccessibilityAssignee: Lucas Gass (lukeg) <lucas>
Status: RESOLVED FIXED QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, matt.blenkinsop, mkstephens, oleonard, wainuiwitikapark
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10
Circulation function:
Attachments: Bug 36140: Correct label for attribute invoice.tt
Bug 36140: Correct label for attribute invoice.tt
Bug 36140: Correct label for attribute invoice.tt

Description Lucas Gass (lukeg) 2024-02-20 23:17:54 UTC
The Invoice label is `<label for="shipmentdate">Invoice number:</label>` when it should be `<label for="invoicenumber">Invoice number:</label>`
Comment 1 Lucas Gass (lukeg) 2024-02-20 23:21:48 UTC
Created attachment 162311 [details] [review]
Bug 36140: Correct label for attribute invoice.tt

To test:
1. Go to /cgi-bin/koha/acqui/invoice.pl?invoiceid=X  where X is the invoice number.
2. Look at the Invoice number with your dev tools, the for attribute is wrong. ( shippingdate )
3. Apply patch and look again, the attribute should correctly be invoicenumber.

Alternatively, just look at the diff of this trivial change. :)
Comment 2 Myka Kennedy Stephens 2024-02-22 16:12:24 UTC
Followed test plan as outlined. Confirmed <label for="shipmentdate">Invoice number:</label> in html when viewing an invoice. Applied patch in Koha Testing Docker. Restarted Apache. Cleared browser cached files. Navigated to invoice and inspected page. Still seeing <label for="shipmentdate">Invoice number:</label>.
Comment 3 Lucas Gass (lukeg) 2024-02-27 21:37:28 UTC
Created attachment 162518 [details] [review]
Bug 36140: Correct label for attribute invoice.tt

To test:
1. Go to /cgi-bin/koha/acqui/invoice.pl?invoiceid=X  where X is the invoice number.
2. Look at the Invoice number with your dev tools, the for attribute is wrong. ( shippingdate )
3. Apply patch and look again, the attribute should correctly be invoicenumber.

Alternatively, just look at the diff of this trivial change. :)
Comment 4 Martin Renvoize (ashimema) 2024-02-29 10:42:01 UTC
Created attachment 162589 [details] [review]
Bug 36140: Correct label for attribute invoice.tt

To test:
1. Go to /cgi-bin/koha/acqui/invoice.pl?invoiceid=X  where X is the invoice number.
2. Look at the Invoice number with your dev tools, the for attribute is wrong. ( shippingdate )
3. Apply patch and look again, the attribute should correctly be invoicenumber.

Alternatively, just look at the diff of this trivial change. :)

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2024-02-29 10:42:31 UTC
Obvious correction of a copy/paste.  Works as intended.. Straight to PQA.
Comment 6 Katrin Fischer 2024-03-07 14:04:36 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-03-11 09:44:40 UTC
Pushed to 23.11.x for 23.11.04
Comment 8 Lucas Gass (lukeg) 2024-03-19 15:37:03 UTC
Backported to 23.05.x for upcoming 23.05.10
Comment 9 Wainui Witika-Park 2025-06-23 07:45:04 UTC
Not backporting to 22.11 unless requested