Bug 36143

Summary: Pop-up window sizes are not consistent
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: Architecture, internals, and plumbingAssignee: Bugs List <koha-bugs>
Status: In Discussion --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: dcook, fridolin.somers, jonathan.druart, martin.renvoize, oleonard
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35554
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 35134    
Bug Blocks:    

Description Pedro Amorim 2024-02-21 13:26:12 UTC
It seems we have width+height specifically defined for each window.popup across the code base.
These are some of the variants I could find, but there may be others:
width=1000,height=600
width=1000,height=375
width=1000,height=575
width=900,height=700
width=800,height=400
width=800,height=550
width=800,height=500
width=700,height=700
width=700,height=600
width=700,height=400
width=700,height=550

This is not great, these should be standardized and configured once, example (values to be discussed):
large: 1000 x 600
medium: 800 x 500
small: 700 x 400
Comment 1 Fridolin Somers 2024-02-23 15:47:58 UTC
Maybe only large and small in enough.

Looks like small popups use around 4/3 ratio.
So small could be width=800,height=600

Large use a more 16/9 ratio.
So large could be width=1024,height=576

Actual width=800 and width=700 goes to small.
Actual width=900 may fit in small, must be validated.
Actual width=1000 goes to large.
Comment 2 Martin Renvoize (ashimema) 2025-03-10 18:10:11 UTC
I'd love to see the approach in bug 35134 extended to here.. I think three sizes of popup make sense and having those three sizes user customisable using the approach in bug 35134 would be even better... I also like that instead of a hard coded default, the default introduced in 35134 is calculated from the window size to start.