Summary: | [23.11 and below] We need tests to check for 'cud-' operations in stable branches (pre-24.05) | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, lucas, m.de.rooy, wainuiwitikapark |
Version: | 23.11 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.04,23.05.10
|
|
Circulation function: | |||
Attachments: |
Bug 36176: Reject cud- for stable branches
Bug 36176: Reject cud- for stable branches Bug 36176: Reject cud- for stable branches Bug 36176: Exclude misc/releases_notes/* |
Description
Nick Clemens (kidclamp)
2024-02-27 14:37:44 UTC
Thanks Nick! Not necessarily selenium tests. We can grep 'cud-', it will be a good and easy start. Created attachment 162536 [details] [review] Bug 36176: Reject cud- for stable branches This patch must be backported into all stable branches. Created attachment 162550 [details] [review] Bug 36176: Reject cud- for stable branches Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 162659 [details] [review] Bug 36176: Reject cud- for stable branches Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> At some point we may need to make this test a bit smarter since cud- may leak into comments, release notes, etc ? Yes sure, this will certainly need to be adjusted, but at least it will be effective for the first months. Even in release notes we should not refer to cud- in stable branches. Pushed to 23.11.x for 23.11.04 Backported to 22.05.x-security for 22.05.20 Backported to 23.05.x for upcoming 23.05.10 Can we exclude `misc/release_notes/*`, this is causing builds to fail for stable releases. Created attachment 163960 [details] [review] Bug 36176: Exclude misc/releases_notes/* (In reply to Lucas Gass from comment #13) > Created attachment 163960 [details] [review] [review] > Bug 36176: Exclude misc/releases_notes/* added to 22.05-x Bug 36176: Exclude misc/releases_notes/* Pushed to 23.11.x Yes, good catch Lucas. Follow-up pushed to 23.05.x. |