Bug 34478 will be adding 'cud-' (create/update/delete) to all actions that change state. We need to ensure these are not backported when fixing bugs - we test to check for this
Thanks Nick!
Not necessarily selenium tests. We can grep 'cud-', it will be a good and easy start.
Created attachment 162536 [details] [review] Bug 36176: Reject cud- for stable branches
This patch must be backported into all stable branches.
Created attachment 162550 [details] [review] Bug 36176: Reject cud- for stable branches Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 162659 [details] [review] Bug 36176: Reject cud- for stable branches Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
At some point we may need to make this test a bit smarter since cud- may leak into comments, release notes, etc ?
Yes sure, this will certainly need to be adjusted, but at least it will be effective for the first months. Even in release notes we should not refer to cud- in stable branches.
Pushed to 23.11.x for 23.11.04
Backported to 22.05.x-security for 22.05.20
Backported to 23.05.x for upcoming 23.05.10
Can we exclude `misc/release_notes/*`, this is causing builds to fail for stable releases.
Created attachment 163960 [details] [review] Bug 36176: Exclude misc/releases_notes/*
(In reply to Lucas Gass from comment #13) > Created attachment 163960 [details] [review] [review] > Bug 36176: Exclude misc/releases_notes/* added to 22.05-x
Bug 36176: Exclude misc/releases_notes/* Pushed to 23.11.x
Yes, good catch Lucas.
Follow-up pushed to 23.05.x.