Bug 36176 - [23.11 and below] We need tests to check for 'cud-' operations in stable branches (pre-24.05)
Summary: [23.11 and below] We need tests to check for 'cud-' operations in stable bran...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 23.11
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-27 14:37 UTC by Nick Clemens (kidclamp)
Modified: 2024-03-27 13:46 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.04,23.05.10


Attachments
Bug 36176: Reject cud- for stable branches (1.41 KB, patch)
2024-02-28 15:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 36176: Reject cud- for stable branches (1.46 KB, patch)
2024-02-28 23:22 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 36176: Reject cud- for stable branches (1.55 KB, patch)
2024-03-01 10:45 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 36176: Exclude misc/releases_notes/* (751 bytes, patch)
2024-03-26 20:32 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2024-02-27 14:37:44 UTC
Bug 34478 will be adding 'cud-' (create/update/delete) to all actions that change state. We need to ensure these are not backported when fixing bugs - we test to check for this
Comment 1 Katrin Fischer 2024-02-27 22:46:09 UTC
Thanks Nick!
Comment 2 Jonathan Druart 2024-02-28 07:28:43 UTC
Not necessarily selenium tests. We can grep 'cud-', it will be a good and easy start.
Comment 3 Jonathan Druart 2024-02-28 15:30:58 UTC
Created attachment 162536 [details] [review]
Bug 36176: Reject cud- for stable branches
Comment 4 Jonathan Druart 2024-02-28 15:31:18 UTC
This patch must be backported into all stable branches.
Comment 5 Lucas Gass 2024-02-28 23:22:04 UTC
Created attachment 162550 [details] [review]
Bug 36176: Reject cud- for stable branches

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 6 Marcel de Rooy 2024-03-01 10:45:30 UTC
Created attachment 162659 [details] [review]
Bug 36176: Reject cud- for stable branches

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Marcel de Rooy 2024-03-01 10:46:14 UTC
At some point we may need to make this test a bit smarter since cud- may leak into comments, release notes, etc ?
Comment 8 Jonathan Druart 2024-03-01 10:56:57 UTC
Yes sure, this will certainly need to be adjusted, but at least it will be effective for the first months.

Even in release notes we should not refer to cud- in stable branches.
Comment 9 Fridolin Somers 2024-03-08 08:15:31 UTC
Pushed to 23.11.x for 23.11.04
Comment 10 wainuiwitikapark 2024-03-18 23:32:27 UTC
Backported to 22.05.x-security for 22.05.20
Comment 11 Lucas Gass 2024-03-19 14:57:14 UTC
Backported to 23.05.x for upcoming 23.05.10
Comment 12 Lucas Gass 2024-03-26 20:31:16 UTC
Can we exclude `misc/release_notes/*`, this is causing builds to fail for stable releases.
Comment 13 Lucas Gass 2024-03-26 20:32:51 UTC
Created attachment 163960 [details] [review]
Bug 36176: Exclude misc/releases_notes/*
Comment 14 wainuiwitikapark 2024-03-26 22:56:34 UTC
(In reply to Lucas Gass from comment #13)
> Created attachment 163960 [details] [review] [review]
> Bug 36176: Exclude misc/releases_notes/*

added to 22.05-x
Comment 15 Fridolin Somers 2024-03-27 06:54:53 UTC
Bug 36176: Exclude misc/releases_notes/*
Pushed to 23.11.x
Comment 16 Jonathan Druart 2024-03-27 07:36:57 UTC
Yes, good catch Lucas.
Comment 17 Lucas Gass 2024-03-27 13:46:21 UTC
Follow-up pushed to 23.05.x.