Summary: | Add othernames to the PatronAutoComplete display | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Patrons | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Needs documenting --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 36204: Add othernames field to PatronAutoComplete display
Bug 36204: Add othernames field to PatronAutoComplete display Bug 36204: Add othernames field to PatronAutoComplete display Bug 36204: Add othernames field to PatronAutoComplete display |
Description
Lucas Gass (lukeg)
2024-02-29 16:52:41 UTC
Created attachment 162610 [details] [review] Bug 36204: Add othernames field to PatronAutoComplete display To test: 1. APPLY PATCH 2. Make sure PatronAutoComplete is on. 3. Find or add othernames to a patron record. 4. Search for that patron and make sure othernames properly displays in the dropdown. 5. Add a middle name to that patron and search again, make sure the display looks good. 6. Remove the othernames field and search again, make sure the display looks good. Created attachment 163028 [details] [review] Bug 36204: Add othernames field to PatronAutoComplete display To test: 1. APPLY PATCH 2. Make sure PatronAutoComplete is on. 3. Find or add othernames to a patron record. 4. Search for that patron and make sure othernames properly displays in the dropdown. 5. Add a middle name to that patron and search again, make sure the display looks good. 6. Remove the othernames field and search again, make sure the display looks good. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 163029 [details] [review] Bug 36204: Add othernames field to PatronAutoComplete display To test: 1. APPLY PATCH 2. Make sure PatronAutoComplete is on. 3. Find or add othernames to a patron record. 4. Search for that patron and make sure othernames properly displays in the dropdown. 5. Add a middle name to that patron and search again, make sure the display looks good. 6. Remove the othernames field and search again, make sure the display looks good. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> This is a trivial change that works as expected, is correctly implemented and no QA complaints. Straight QA. Not offended if someone else wants to give it another round of testing. Can you please rebase? 163029 - Bug 36204: Add othernames field to PatronAutoComplete display Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36204: Add othernames field to PatronAutoComplete display Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/staff-global.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/staff-global.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/staff-global.js error: Failed to merge in the changes. Patch failed at 0001 Bug 36204: Add othernames field to PatronAutoComplete display hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-36204-Add-othernames-field-to-PatronAutoComple-9i58z0qw.patch kohadev-koha@kohadevbox:koha(main|AM 1/1)$ Created attachment 165223 [details] [review] Bug 36204: Add othernames field to PatronAutoComplete display To test: 1. APPLY PATCH 2. Make sure PatronAutoComplete is on. 3. Find or add othernames to a patron record. 4. Search for that patron and make sure othernames properly displays in the dropdown. 5. Add a middle name to that patron and search again, make sure the display looks good. 6. Remove the othernames field and search again, make sure the display looks good. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> rebased for current main, back to PQA (In reply to Lucas Gass from comment #7) > rebased for current main, back to PQA Will be back for this one on Monday! On the other patron pages we display the othername in parenthesis after the first name. The patron auto-complete is a little differently formatted, but I feel like this would be more consistent: Suggested display: Schneider, Nicole (othername) Current display: Schneide, Nicole othername ---- Patron account (for comparison) Nicole (othername) Schneider Patron search results (for comparison) Schneider, Nicole (othername) Updated in a follow-up (hope you agree). Pushed for 24.05! Well done everyone, thank you! Does not apply easy on 23.11.x Not backported |