Bug 36204 - Add othernames to the PatronAutoComplete display
Summary: Add othernames to the PatronAutoComplete display
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-29 16:52 UTC by Lucas Gass
Modified: 2024-04-19 17:56 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 36204: Add othernames field to PatronAutoComplete display (1.43 KB, patch)
2024-02-29 16:55 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 36204: Add othernames field to PatronAutoComplete display (1.49 KB, patch)
2024-03-11 13:19 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 36204: Add othernames field to PatronAutoComplete display (1.49 KB, patch)
2024-03-11 13:20 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 36204: Add othernames field to PatronAutoComplete display (1.45 KB, patch)
2024-04-19 17:33 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2024-02-29 16:52:41 UTC
Some librarians would like to able to see the othernames field in the PatronAutoComplete dropdown to help differentiate between patrons.
Comment 1 Lucas Gass 2024-02-29 16:55:58 UTC
Created attachment 162610 [details] [review]
Bug 36204: Add othernames field to PatronAutoComplete display

To test:
1. APPLY PATCH
2. Make sure PatronAutoComplete is on.
3. Find or add othernames to a patron record.
4. Search for that patron and make sure othernames properly displays in the dropdown.
5. Add a middle name to that patron and search again, make sure the display looks good.
6. Remove the othernames field and search again, make sure the display looks good.
Comment 2 Tomás Cohen Arazi 2024-03-11 13:19:54 UTC
Created attachment 163028 [details] [review]
Bug 36204: Add othernames field to PatronAutoComplete display

To test:
1. APPLY PATCH
2. Make sure PatronAutoComplete is on.
3. Find or add othernames to a patron record.
4. Search for that patron and make sure othernames properly displays in the dropdown.
5. Add a middle name to that patron and search again, make sure the display looks good.
6. Remove the othernames field and search again, make sure the display looks good.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi 2024-03-11 13:20:12 UTC
Created attachment 163029 [details] [review]
Bug 36204: Add othernames field to PatronAutoComplete display

To test:
1. APPLY PATCH
2. Make sure PatronAutoComplete is on.
3. Find or add othernames to a patron record.
4. Search for that patron and make sure othernames properly displays in the dropdown.
5. Add a middle name to that patron and search again, make sure the display looks good.
6. Remove the othernames field and search again, make sure the display looks good.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2024-03-11 13:21:57 UTC
This is a trivial change that works as expected, is correctly implemented and no QA complaints.

Straight QA. Not offended if someone else wants to give it another round of testing.
Comment 5 Katrin Fischer 2024-04-19 17:28:10 UTC
Can you please rebase?

163029 - Bug 36204: Add othernames field to PatronAutoComplete display

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 36204: Add othernames field to PatronAutoComplete display
Using index info to reconstruct a base tree...
M	koha-tmpl/intranet-tmpl/prog/js/staff-global.js
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/js/staff-global.js
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/staff-global.js
error: Failed to merge in the changes.
Patch failed at 0001 Bug 36204: Add othernames field to PatronAutoComplete display
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-36204-Add-othernames-field-to-PatronAutoComple-9i58z0qw.patch
kohadev-koha@kohadevbox:koha(main|AM 1/1)$
Comment 6 Lucas Gass 2024-04-19 17:33:39 UTC
Created attachment 165223 [details] [review]
Bug 36204: Add othernames field to PatronAutoComplete display

To test:
1. APPLY PATCH
2. Make sure PatronAutoComplete is on.
3. Find or add othernames to a patron record.
4. Search for that patron and make sure othernames properly displays in the dropdown.
5. Add a middle name to that patron and search again, make sure the display looks good.
6. Remove the othernames field and search again, make sure the display looks good.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 7 Lucas Gass 2024-04-19 17:35:51 UTC
rebased for current main, back to PQA
Comment 8 Katrin Fischer 2024-04-19 17:56:55 UTC
(In reply to Lucas Gass from comment #7)
> rebased for current main, back to PQA

Will be back for this one on Monday!