Bug 36224

Summary: It looks like spsuggest functionality was removed years ago, but the templates still refer to it
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: TemplatesAssignee: Lucas Gass <lucas>
Status: Pushed to stable --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, lucas, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10
Bug Depends on: 2539    
Bug Blocks:    
Attachments: Bug 36224: Remove unused spsuggest from templates
Bug 36224: Remove unused spsuggest from templates
Bug 36224: Remove unused spsuggest from templates

Description Martin Renvoize 2024-03-04 16:25:18 UTC
opac-search.tt still refers to spsuggest but the git logs suggest the functionality was never fully implimented and the system preferences were removed long ago.. but they missed the template block.
Comment 1 Lucas Gass 2024-03-05 16:03:10 UTC
Created attachment 162768 [details] [review]
Bug 36224: Remove unused spsuggest from templates

To test:
-APPLY PATCH
-Review the OPAC results and staff interface results pages.
-Nothing should change, it would be impossible to end up inside of the [% IF koha_spsuggest %] condition because there is nothing like that in the scripts!
Comment 2 David Nind 2024-03-10 02:12:28 UTC
Created attachment 163014 [details] [review]
Bug 36224: Remove unused spsuggest from templates

To test:
-APPLY PATCH
-Review the OPAC results and staff interface results pages.
-Nothing should change, it would be impossible to end up inside of the [% IF koha_spsuggest %] condition because there is nothing like that in the scripts!

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2024-03-15 10:06:36 UTC
Created attachment 163186 [details] [review]
Bug 36224: Remove unused spsuggest from templates

To test:
-APPLY PATCH
-Review the OPAC results and staff interface results pages.
-Nothing should change, it would be impossible to end up inside of the [% IF koha_spsuggest %] condition because there is nothing like that in the scripts!

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-03-15 14:40:23 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-03-18 09:21:33 UTC
Pushed to 23.11.x for 23.11.04
Comment 6 Lucas Gass 2024-03-19 21:47:21 UTC
Backported to 23.05.x for upcoming 23.05.10