Summary: | Cannot edit identity provider after creation | ||
---|---|---|---|
Product: | Koha | Reporter: | Olivier Hubert <olivier.hubert> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | David Cook <dcook> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, dcook, fridolin.somers, gmcharlt, koha, lucas, nick, olivier.hubert |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the identity provider and domain forms so that the information is now editable (Administration > Additional parameters > Identity providers).
|
Version(s) released in: |
24.11.00,24.05.04
|
Circulation function: | |||
Attachments: |
Bug 36276: Fix editing of identity provider and domains
Bug 36276: Fix editing of identity provider and domains Bug 36276: Fix editing of identity provider and domains |
Description
Olivier Hubert
2024-03-07 15:12:42 UTC
I can confirm this behaviour. I can confirm this, too. Happens also, if you want to edit an Identity Provider Domain. Created attachment 168682 [details] [review] Bug 36276: Fix editing of identity provider and domains This patch fixes identity_providers.pl to remove the "cud-" prefix for two operations which are not POSTed: editing identity providers and editing domains. To test, apply the patch and restart services. - Go to Administration -> Identity providers. - If necessary, create an identity provider and then click "Manage domains" -> New identity provider domain to create a new domain. - From the list of domains, click "Edit" - The edit form should appear with all the correct details prefilled. - Check that the page title, breadcrumbs, and page header all show the correct domain. - Make a change to the domain and confirm that the changes are saved. - From the list of identity providers, click "Edit" - This form should also load correctly. - Submitted changes should be saved correctly. Sponsored-by: Athens County Public Libraries Created attachment 168683 [details] [review] Bug 36276: Fix editing of identity provider and domains This patch fixes identity_providers.pl to remove the "cud-" prefix for two operations which are not POSTed: editing identity providers and editing domains. To test, apply the patch and restart services. - Go to Administration -> Identity providers. - If necessary, create an identity provider and then click "Manage domains" -> New identity provider domain to create a new domain. - From the list of domains, click "Edit" - The edit form should appear with all the correct details prefilled. - Check that the page title, breadcrumbs, and page header all show the correct domain. - Make a change to the domain and confirm that the changes are saved. - From the list of identity providers, click "Edit" - This form should also load correctly. - Submitted changes should be saved correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Created attachment 168686 [details] [review] Bug 36276: Fix editing of identity provider and domains This patch fixes identity_providers.pl to remove the "cud-" prefix for two operations which are not POSTed: editing identity providers and editing domains. To test, apply the patch and restart services. - Go to Administration -> Identity providers. - If necessary, create an identity provider and then click "Manage domains" -> New identity provider domain to create a new domain. - From the list of domains, click "Edit" - The edit form should appear with all the correct details prefilled. - Check that the page title, breadcrumbs, and page header all show the correct domain. - Make a change to the domain and confirm that the changes are saved. - From the list of identity providers, click "Edit" - This form should also load correctly. - Submitted changes should be saved correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Cook <dcook@prosentient.com.au> Thanks, Owen. Legend! For my understanding... I thought that any operation that requires a data change should use POST and cud- - Why are we moving the other direction here with these patches? Pushed for 24.11! Well done everyone, thank you! (In reply to Katrin Fischer from comment #7) > For my understanding... I thought that any operation that requires a data > change should use POST and cud- - Why are we moving the other direction here > with these patches? The edit_form op is loading the form, it's read only to populate the page. When edits are saved the op is 'cud-edit_save' (In reply to Nick Clemens (kidclamp) from comment #9) > (In reply to Katrin Fischer from comment #7) > > For my understanding... I thought that any operation that requires a data > > change should use POST and cud- - Why are we moving the other direction here > > with these patches? > > The edit_form op is loading the form, it's read only to populate the page. > When edits are saved the op is 'cud-edit_save' Thanks for explaining! Backported to 24.05.x for upcoming 24.05.04 CUD not in 23.11.x This fixes a bug - no change to the interface, no changes required to the manual. |