Summary: | Unnecessary JS code in member.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, nick, pedro.amorim |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 36334: Remove unnecessary JS code from member.tt
Bug 36334: Remove unnecessary JS code from member.tt Bug 36334: Remove unnecessary JS code from member.tt Bug 36334: (follow-up) Restore selection of previous values in sidebar Bug 36334: (follow-up) Restore selection of previous values in sidebar |
Description
Jonathan Druart
2024-03-15 14:38:14 UTC
Created attachment 163249 [details] [review] Bug 36334: Remove unnecessary JS code from member.tt This was initially written to set the input/select in the form in the left side of the main patron search page. But this is now done in patron-search.inc: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: <input type="text" class="search_patron_filter" value="[% search_filter | html %]" class="focus" /> I don't see how/when this code is still used. Additionally: #searchmember_filter => does not exist, it's .search_patron_filter $("searchfieldstype_filter").val("[% searchfieldstype | html %]"); => Not a valid selector Nick, Pedro, could you confirm that? Created attachment 163258 [details] [review] Bug 36334: Remove unnecessary JS code from member.tt This was initially written to set the input/select in the form in the left side of the main patron search page. But this is now done in patron-search.inc: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: <input type="text" class="search_patron_filter" value="[% search_filter | html %]" class="focus" /> I don't see how/when this code is still used. Additionally: #searchmember_filter => does not exist, it's .search_patron_filter $("searchfieldstype_filter").val("[% searchfieldstype | html %]"); => Not a valid selector Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 163268 [details] [review] Bug 36334: Remove unnecessary JS code from member.tt This was initially written to set the input/select in the form in the left side of the main patron search page. But this is now done in patron-search.inc: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: <input type="text" class="search_patron_filter" value="[% search_filter | html %]" class="focus" /> I don't see how/when this code is still used. Additionally: #searchmember_filter => does not exist, it's .search_patron_filter $("searchfieldstype_filter").val("[% searchfieldstype | html %]"); => Not a valid selector Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 163269 [details] [review] Bug 36334: (follow-up) Restore selection of previous values in sidebar Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 163275 [details] [review] Bug 36334: (follow-up) Restore selection of previous values in sidebar Before and after the first patch the values for category and library were not populated To test: 1 - With nothing applied search in the top bar, clicking the 'settings' button 2 - Select a search field, search type, category, and library 3 - Perform search, note only search field and search type are populated 4 - Apply first path, repeat, same result 5 - Apply this patch, repeat 6 - Confirm all four fields now populate in sidebar Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Jonathan, can you confirm my follow-up? (In reply to Nick Clemens from comment #7) > Jonathan, can you confirm my follow-up? Yes, good catch! Thanks a lot! Pushed for 24.05! Well done everyone, thank you! Code has changed in master since Bug 35329 So I prefer not to backport |