Bug 36353

Summary:	Ensure consistent empty selection style for guarantor relationship drop-downs
Product:	Koha	Reporter:	Laura Escamilla <Laura.escamilla>
Component:	Patrons	Assignee:	Laura Escamilla <Laura.escamilla>
Status:	Pushed to oldstable ---	QA Contact:	Marcel de Rooy <m.de.rooy>
Severity:	trivial
Priority:	P5 - low	CC:	fridolin.somers, gmcharlt, kyle.m.hall, lucas, m.de.rooy
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.05.00,23.11.06,23.05.12
Circulation function:
Attachments:	Bug 36353: Update relationship value so that it is blank and consistent with other forms Bug 36353: Update relationship value so that it is blank and consistent with other forms Bug 36353: Update relationship value so that it is blank and consistent with other forms

Description Laura Escamilla 2024-03-18 19:23:44 UTC

To Replicate:

1. Choose a user eligible for a guarantor.
   1. Modify the user profile to include a new guarantor.
   2. Upon selecting a guarantor, observe that the empty option in the 'Relationship' drop-down appears as a blank box.

2. Select a user eligible for a guarantee.
   1. Navigate to "Add Guarantee" in the top menu.
   2. The guarantor field is automatically populated with the selected user. However, note that the 'Relationship' drop-down displays the empty option as 'Empty record.'

To Ensure Consistency:

Both 'Relationship' drop-downs in the Patron Guarantor section should display a blank option consistently.

Comment 1 Laura Escamilla 2024-03-18 19:49:15 UTC

Created attachment 163370 [details] [review]
Bug 36353: Update relationship value so that it is blank and consistent with other forms

To Test:

1. Choose a User Eligible for a Guarantor:
   1. Modify the user profile to include a new guarantor.
   2. Upon selecting a guarantor, ensure that the empty option in the 'Relationship' dropdown appears as a blank box.

2. Select a User Eligible for a Guarantee:
   1. Navigate to "Add Guarantee" in the top menu.
   2. Verify that the guarantor field is automatically populated with the selected user.
   3. Confirm that the 'Relationship' dropdown displays the empty option as 'Empty record.'

3. Apply Patch and Refresh the Page for Step 2:
   1. After applying the patch, refresh the page for step 2.
   2. Ensure that the empty option value for 'Relationship' is now displayed as blank.

4. Sign Off and Have a Great Day! ﷐[U+1F60A]﷑﷐[U+1F389]﷑#

Comment 2 Andrew Fuerste-Henry 2024-03-22 15:30:21 UTC

Created attachment 163714 [details] [review]
Bug 36353: Update relationship value so that it is blank and consistent with other forms

To Test:

1. Choose a User Eligible for a Guarantor:
   1. Modify the user profile to include a new guarantor.
   2. Upon selecting a guarantor, ensure that the empty option in the 'Relationship' dropdown appears as a blank box.

2. Select a User Eligible for a Guarantee:
   1. Navigate to "Add Guarantee" in the top menu.
   2. Verify that the guarantor field is automatically populated with the selected user.
   3. Confirm that the 'Relationship' dropdown displays the empty option as 'Empty record.'

3. Apply Patch and Refresh the Page for Step 2:
   1. After applying the patch, refresh the page for step 2.
   2. Ensure that the empty option value for 'Relationship' is now displayed as blank.

4. Sign Off and Have a Great Day! ﷐[U+1F60A]﷑﷐[U+1F389]﷑#

Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>

Comment 3 Marcel de Rooy 2024-04-05 07:16:31 UTC

Created attachment 164454 [details] [review]
Bug 36353: Update relationship value so that it is blank and consistent with other forms

To Test:

1. Choose a User Eligible for a Guarantor:
   1. Modify the user profile to include a new guarantor.
   2. Upon selecting a guarantor, ensure that the empty option in the 'Relationship' dropdown appears as a blank box.

2. Select a User Eligible for a Guarantee:
   1. Navigate to "Add Guarantee" in the top menu.
   2. Verify that the guarantor field is automatically populated with the selected user.
   3. Confirm that the 'Relationship' dropdown displays the empty option as 'Empty record.'

3. Apply Patch and Refresh the Page for Step 2:
   1. After applying the patch, refresh the page for step 2.
   2. Ensure that the empty option value for 'Relationship' is now displayed as blank.

4. Sign Off and Have a Great Day! ﷐[U+1F60A]﷑﷐[U+1F389]﷑#

Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 4 Katrin Fischer 2024-04-05 09:52:55 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 5 Fridolin Somers 2024-05-23 11:58:22 UTC

Pushed to 23.11.x for 23.11.06

Comment 6 Lucas Gass (lukeg) 2024-05-28 17:37:03 UTC

Backported to 23.05.x for upcoming 23.05.12