Bug 36353 - Ensure consistent empty selection style for guarantor relationship drop-downs
Summary: Ensure consistent empty selection style for guarantor relationship drop-downs
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Laura Escamilla
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-18 19:23 UTC by Laura Escamilla
Modified: 2024-05-28 17:37 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12
Circulation function:


Attachments
Bug 36353: Update relationship value so that it is blank and consistent with other forms (2.50 KB, patch)
2024-03-18 19:49 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 36353: Update relationship value so that it is blank and consistent with other forms (2.56 KB, patch)
2024-03-22 15:30 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 36353: Update relationship value so that it is blank and consistent with other forms (2.65 KB, patch)
2024-04-05 07:16 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Laura Escamilla 2024-03-18 19:23:44 UTC
To Replicate:

1. Choose a user eligible for a guarantor.
   1. Modify the user profile to include a new guarantor.
   2. Upon selecting a guarantor, observe that the empty option in the 'Relationship' drop-down appears as a blank box.

2. Select a user eligible for a guarantee.
   1. Navigate to "Add Guarantee" in the top menu.
   2. The guarantor field is automatically populated with the selected user. However, note that the 'Relationship' drop-down displays the empty option as 'Empty record.'

To Ensure Consistency:

Both 'Relationship' drop-downs in the Patron Guarantor section should display a blank option consistently.
Comment 1 Laura Escamilla 2024-03-18 19:49:15 UTC
Created attachment 163370 [details] [review]
Bug 36353: Update relationship value so that it is blank and consistent with other forms

To Test:

1. Choose a User Eligible for a Guarantor:
   1. Modify the user profile to include a new guarantor.
   2. Upon selecting a guarantor, ensure that the empty option in the 'Relationship' dropdown appears as a blank box.

2. Select a User Eligible for a Guarantee:
   1. Navigate to "Add Guarantee" in the top menu.
   2. Verify that the guarantor field is automatically populated with the selected user.
   3. Confirm that the 'Relationship' dropdown displays the empty option as 'Empty record.'

3. Apply Patch and Refresh the Page for Step 2:
   1. After applying the patch, refresh the page for step 2.
   2. Ensure that the empty option value for 'Relationship' is now displayed as blank.

4. Sign Off and Have a Great Day! ﷐[U+1F60A]﷑﷐[U+1F389]﷑#
Comment 2 Andrew Fuerste-Henry 2024-03-22 15:30:21 UTC
Created attachment 163714 [details] [review]
Bug 36353: Update relationship value so that it is blank and consistent with other forms

To Test:

1. Choose a User Eligible for a Guarantor:
   1. Modify the user profile to include a new guarantor.
   2. Upon selecting a guarantor, ensure that the empty option in the 'Relationship' dropdown appears as a blank box.

2. Select a User Eligible for a Guarantee:
   1. Navigate to "Add Guarantee" in the top menu.
   2. Verify that the guarantor field is automatically populated with the selected user.
   3. Confirm that the 'Relationship' dropdown displays the empty option as 'Empty record.'

3. Apply Patch and Refresh the Page for Step 2:
   1. After applying the patch, refresh the page for step 2.
   2. Ensure that the empty option value for 'Relationship' is now displayed as blank.

4. Sign Off and Have a Great Day! ﷐[U+1F60A]﷑﷐[U+1F389]﷑#

Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Comment 3 Marcel de Rooy 2024-04-05 07:16:31 UTC
Created attachment 164454 [details] [review]
Bug 36353: Update relationship value so that it is blank and consistent with other forms

To Test:

1. Choose a User Eligible for a Guarantor:
   1. Modify the user profile to include a new guarantor.
   2. Upon selecting a guarantor, ensure that the empty option in the 'Relationship' dropdown appears as a blank box.

2. Select a User Eligible for a Guarantee:
   1. Navigate to "Add Guarantee" in the top menu.
   2. Verify that the guarantor field is automatically populated with the selected user.
   3. Confirm that the 'Relationship' dropdown displays the empty option as 'Empty record.'

3. Apply Patch and Refresh the Page for Step 2:
   1. After applying the patch, refresh the page for step 2.
   2. Ensure that the empty option value for 'Relationship' is now displayed as blank.

4. Sign Off and Have a Great Day! ﷐[U+1F60A]﷑﷐[U+1F389]﷑#

Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-04-05 09:52:55 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-05-23 11:58:22 UTC
Pushed to 23.11.x for 23.11.06
Comment 6 Lucas Gass (lukeg) 2024-05-28 17:37:03 UTC
Backported to 23.05.x for upcoming 23.05.12