Summary: | FrameworkPlugin.t does not rollback properly | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, lucas |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36277 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.04,23.05.12
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 25515 | ||
Attachments: | Bug 36356: Fix rollback from FrameworkPlugin.t |
Description
Jonathan Druart
2024-03-19 08:16:37 UTC
Created attachment 163379 [details] [review] Bug 36356: Fix rollback from FrameworkPlugin.t rollback ineffective with AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1651. I have not investigated more than that. Reaching this was already the end of a long road... (see comment 0) Test plan: 0. Do not apply this patch 1. select count(*) from branches Note the value 2. Run prove t/db_dependent/FrameworkPlugin.t => There is a warning 3. Repeat 1. => There are too many libraries! 4. Apply the patch, retry 1, 2, 3 => No warning, no library added by the tests (In reply to Jonathan Druart from comment #0) > Bug 36355 because we are fetching the library list from the REST API This is not correct. See there for more info. Change is small, let's do the final test on Jenkins (passing locally). Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.04 Backported to 23.05.x for upcoming 23.05.12 |