Bug 36375

Summary:	Inconsistencies in ContentWarningField display
Product:	Koha	Reporter:	Fridolin Somers <fridolin.somers>
Component:	Cataloging	Assignee:	Martin Renvoize (ashimema) <martin.renvoize>
Status:	Pushed to stable ---	QA Contact:	Nick Clemens (kidclamp) <nick>
Severity:	normal
Priority:	P5 - low	CC:	lucas, m.de.rooy, martin.renvoize, wainuiwitikapark
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.11.00,24.05.06
Circulation function:
Bug Depends on:	31123
Bug Blocks:	37082
Attachments:	Bug 36375: Fix inconsistencies in content warning display Bug 36375: Fix inconsistencies in content warning display Bug 36375: Fix inconsistencies in content warning display Bug 36375: Fix inconsistencies in content warning display

Description Fridolin Somers 2024-03-20 15:29:06 UTC

Bug 31123 add code in XSLT files for results and details pages OPAC and staff interface.
Looks like those 4 displays are different, they use $a and $u then call subfieldSelect with different values :

koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl:
  <xsl:with-param name="codes">bcdefghijklmnopqrstvwxyz</xsl:with-param>
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:
  <xsl:with-param name="codes">abcdefgijklnou</xsl:with-param>
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl:
  <xsl:with-param name="codes">bcdefghijklmnopqrstvwyz</xsl:with-param>
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:
  <xsl:with-param name="codes">bcdefghijklmnopqrstvwyz</xsl:with-param>

Using $a and $u is a mistake since they are displayed in above code.

In Bug 36370 I used code from MARC21slim2intranetDetail.xsl : bcdefghijklmnopqrstvwxyz
Looks like it is the better one.

Also makes sens to create a template in MARC21slimUtils.xsl

Comment 1 Martin Renvoize (ashimema) 2024-10-01 12:35:20 UTC

Created attachment 172261 [details] [review]
Bug 36375: Fix inconsistencies in content warning display

As suggested by Fridolin, we move the display into a template to improve
consistency and maintanence and whilst doing this we also pick the
suggested subfield selection.

Comment 2 Martin Renvoize (ashimema) 2024-10-01 12:49:03 UTC

Created attachment 172262 [details] [review]
Bug 36375: Fix inconsistencies in content warning display

As suggested by Fridolin, we move the display into a template to improve
consistency and maintanence and whilst doing this we also pick the
suggested subfield selection.

Comment 3 Martin Renvoize (ashimema) 2024-10-01 12:52:31 UTC

*** Bug 37082 has been marked as a duplicate of this bug. ***

Comment 4 Nick Clemens (kidclamp) 2024-10-01 16:48:24 UTC

Created attachment 172284 [details] [review]
Bug 36375: Fix inconsistencies in content warning display

As suggested by Fridolin, we move the display into a template to improve
consistency and maintanence and whilst doing this we also pick the
suggested subfield selection.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 5 Martin Renvoize (ashimema) 2024-10-08 11:09:59 UTC

Created attachment 172516 [details] [review]
Bug 36375: Fix inconsistencies in content warning display

As suggested by Fridolin, we move the display into a template to improve
consistency and maintanence and whilst doing this we also pick the
suggested subfield selection.

Signed-off-by: Hannah Prince <hannah.prince@uhb.nhs.uk>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 6 Katrin Fischer 2024-10-11 09:06:36 UTC

Nice clean-up!

I see we have something similar in the UNIMARC files.

Comment 7 Katrin Fischer 2024-10-11 09:15:28 UTC

Pushed for 24.11!

Well done everyone, thank you!

Comment 8 Lucas Gass (lukeg) 2024-11-18 22:51:11 UTC

Backported to 24.05.x for upcoming 24.05.06