Bug 36375 - Inconsistencies in ContentWarningField display
Summary: Inconsistencies in ContentWarningField display
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Martin Renvoize (ashimema)
QA Contact: Nick Clemens (kidclamp)
URL:
Keywords:
: 37082 (view as bug list)
Depends on: 31123
Blocks: 37082
  Show dependency treegraph
 
Reported: 2024-03-20 15:29 UTC by Fridolin Somers
Modified: 2024-10-11 09:15 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 36375: Fix inconsistencies in content warning display (15.82 KB, patch)
2024-10-01 12:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 36375: Fix inconsistencies in content warning display (15.79 KB, patch)
2024-10-01 12:49 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 36375: Fix inconsistencies in content warning display (15.84 KB, patch)
2024-10-01 16:48 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 36375: Fix inconsistencies in content warning display (15.90 KB, patch)
2024-10-08 11:09 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2024-03-20 15:29:06 UTC
Bug 31123 add code in XSLT files for results and details pages OPAC and staff interface.
Looks like those 4 displays are different, they use $a and $u then call subfieldSelect with different values :

koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl:
  <xsl:with-param name="codes">bcdefghijklmnopqrstvwxyz</xsl:with-param>
koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:
  <xsl:with-param name="codes">abcdefgijklnou</xsl:with-param>
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl:
  <xsl:with-param name="codes">bcdefghijklmnopqrstvwyz</xsl:with-param>
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:
  <xsl:with-param name="codes">bcdefghijklmnopqrstvwyz</xsl:with-param>

Using $a and $u is a mistake since they are displayed in above code.

In Bug 36370 I used code from MARC21slim2intranetDetail.xsl : bcdefghijklmnopqrstvwxyz
Looks like it is the better one.

Also makes sens to create a template in MARC21slimUtils.xsl
Comment 1 Martin Renvoize (ashimema) 2024-10-01 12:35:20 UTC
Created attachment 172261 [details] [review]
Bug 36375: Fix inconsistencies in content warning display

As suggested by Fridolin, we move the display into a template to improve
consistency and maintanence and whilst doing this we also pick the
suggested subfield selection.
Comment 2 Martin Renvoize (ashimema) 2024-10-01 12:49:03 UTC
Created attachment 172262 [details] [review]
Bug 36375: Fix inconsistencies in content warning display

As suggested by Fridolin, we move the display into a template to improve
consistency and maintanence and whilst doing this we also pick the
suggested subfield selection.
Comment 3 Martin Renvoize (ashimema) 2024-10-01 12:52:31 UTC
*** Bug 37082 has been marked as a duplicate of this bug. ***
Comment 4 Nick Clemens (kidclamp) 2024-10-01 16:48:24 UTC
Created attachment 172284 [details] [review]
Bug 36375: Fix inconsistencies in content warning display

As suggested by Fridolin, we move the display into a template to improve
consistency and maintanence and whilst doing this we also pick the
suggested subfield selection.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Martin Renvoize (ashimema) 2024-10-08 11:09:59 UTC
Created attachment 172516 [details] [review]
Bug 36375: Fix inconsistencies in content warning display

As suggested by Fridolin, we move the display into a template to improve
consistency and maintanence and whilst doing this we also pick the
suggested subfield selection.

Signed-off-by: Hannah Prince <hannah.prince@uhb.nhs.uk>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Katrin Fischer 2024-10-11 09:06:36 UTC
Nice clean-up!

I see we have something similar in the UNIMARC files.
Comment 7 Katrin Fischer 2024-10-11 09:15:28 UTC
Pushed for 24.11!

Well done everyone, thank you!