Bug 31123 add code in XSLT files for results and details pages OPAC and staff interface. Looks like those 4 displays are different, they use $a and $u then call subfieldSelect with different values : koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl: <xsl:with-param name="codes">bcdefghijklmnopqrstvwxyz</xsl:with-param> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl: <xsl:with-param name="codes">abcdefgijklnou</xsl:with-param> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl: <xsl:with-param name="codes">bcdefghijklmnopqrstvwyz</xsl:with-param> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl: <xsl:with-param name="codes">bcdefghijklmnopqrstvwyz</xsl:with-param> Using $a and $u is a mistake since they are displayed in above code. In Bug 36370 I used code from MARC21slim2intranetDetail.xsl : bcdefghijklmnopqrstvwxyz Looks like it is the better one. Also makes sens to create a template in MARC21slimUtils.xsl
Created attachment 172261 [details] [review] Bug 36375: Fix inconsistencies in content warning display As suggested by Fridolin, we move the display into a template to improve consistency and maintanence and whilst doing this we also pick the suggested subfield selection.
Created attachment 172262 [details] [review] Bug 36375: Fix inconsistencies in content warning display As suggested by Fridolin, we move the display into a template to improve consistency and maintanence and whilst doing this we also pick the suggested subfield selection.
*** Bug 37082 has been marked as a duplicate of this bug. ***
Created attachment 172284 [details] [review] Bug 36375: Fix inconsistencies in content warning display As suggested by Fridolin, we move the display into a template to improve consistency and maintanence and whilst doing this we also pick the suggested subfield selection. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 172516 [details] [review] Bug 36375: Fix inconsistencies in content warning display As suggested by Fridolin, we move the display into a template to improve consistency and maintanence and whilst doing this we also pick the suggested subfield selection. Signed-off-by: Hannah Prince <hannah.prince@uhb.nhs.uk> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice clean-up! I see we have something similar in the UNIMARC files.
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11
Not pushed to LTS(22.11.x). Backport only major critical and security issues. Marked Resolved