Bug 36390

Summary:	Two minor OPAC CSS fixes
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	OPAC	Assignee:	Owen Leonard <oleonard>
Status:	Pushed to oldstable ---	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	fridolin.somers, lucas
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.05.00,23.11.06,23.05.12
Circulation function:
Attachments:	Bug 36390: Two minor OPAC CSS fixes Bug 36390: Two minor OPAC CSS fixes Bug 36390: Two minor OPAC CSS fixes

Description Owen Leonard 2024-03-21 18:29:20 UTC

1. Some Font Awesome icons are not getting styled correctly because we forgot to update the class list to include .fa-solid.

2. The floating toolbar on pages like catalog search results has an unwanted top margin.

Comment 1 Owen Leonard 2024-03-21 18:42:55 UTC

Created attachment 163649 [details] [review]
Bug 36390: Two minor OPAC CSS fixes

This patch makes corrections to OPAC CSS to address two small issues.

To test, apply the patch and rebuild the OPAC CSS.

- Perform a catalog search which will return multiple results..
- In the table of search results, check the icon and text for the
  controls under each title: "Place hold", "Add tag", "Add to cart" etc.
  - The colors should be consistent, with a slightly darker blue for the
    icons.
- Scroll down until the table header "sticks" to the top of the
  viewport.
- There should be no gap between the header row with the pagination
  links and the row with the "Select all", "Clear all", etc. controls.

Comment 2 Lucas Gass (lukeg) 2024-03-21 19:45:44 UTC

Created attachment 163650 [details] [review]
Bug 36390: Two minor OPAC CSS fixes

This patch makes corrections to OPAC CSS to address two small issues.

To test, apply the patch and rebuild the OPAC CSS.

- Perform a catalog search which will return multiple results..
- In the table of search results, check the icon and text for the
  controls under each title: "Place hold", "Add tag", "Add to cart" etc.
  - The colors should be consistent, with a slightly darker blue for the
    icons.
- Scroll down until the table header "sticks" to the top of the
  viewport.
- There should be no gap between the header row with the pagination
  links and the row with the "Select all", "Clear all", etc. controls.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Comment 3 Lucas Gass (lukeg) 2024-03-21 19:46:02 UTC

Created attachment 163651 [details] [review]
Bug 36390: Two minor OPAC CSS fixes

This patch makes corrections to OPAC CSS to address two small issues.

To test, apply the patch and rebuild the OPAC CSS.

- Perform a catalog search which will return multiple results..
- In the table of search results, check the icon and text for the
  controls under each title: "Place hold", "Add tag", "Add to cart" etc.
  - The colors should be consistent, with a slightly darker blue for the
    icons.
- Scroll down until the table header "sticks" to the top of the
  viewport.
- There should be no gap between the header row with the pagination
  links and the row with the "Select all", "Clear all", etc. controls.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Comment 4 Katrin Fischer 2024-05-06 09:07:41 UTC

Picked from QA queue, reviewed and tested.

Comment 5 Katrin Fischer 2024-05-06 09:19:02 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 6 Fridolin Somers 2024-05-24 13:43:40 UTC

Pushed to 23.11.x for 23.11.06

Comment 7 Lucas Gass (lukeg) 2024-05-28 21:40:12 UTC

Backported to 23.05.x for upcoming 23.05.12