1. Some Font Awesome icons are not getting styled correctly because we forgot to update the class list to include .fa-solid. 2. The floating toolbar on pages like catalog search results has an unwanted top margin.
Created attachment 163649 [details] [review] Bug 36390: Two minor OPAC CSS fixes This patch makes corrections to OPAC CSS to address two small issues. To test, apply the patch and rebuild the OPAC CSS. - Perform a catalog search which will return multiple results.. - In the table of search results, check the icon and text for the controls under each title: "Place hold", "Add tag", "Add to cart" etc. - The colors should be consistent, with a slightly darker blue for the icons. - Scroll down until the table header "sticks" to the top of the viewport. - There should be no gap between the header row with the pagination links and the row with the "Select all", "Clear all", etc. controls.
Created attachment 163650 [details] [review] Bug 36390: Two minor OPAC CSS fixes This patch makes corrections to OPAC CSS to address two small issues. To test, apply the patch and rebuild the OPAC CSS. - Perform a catalog search which will return multiple results.. - In the table of search results, check the icon and text for the controls under each title: "Place hold", "Add tag", "Add to cart" etc. - The colors should be consistent, with a slightly darker blue for the icons. - Scroll down until the table header "sticks" to the top of the viewport. - There should be no gap between the header row with the pagination links and the row with the "Select all", "Clear all", etc. controls. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 163651 [details] [review] Bug 36390: Two minor OPAC CSS fixes This patch makes corrections to OPAC CSS to address two small issues. To test, apply the patch and rebuild the OPAC CSS. - Perform a catalog search which will return multiple results.. - In the table of search results, check the icon and text for the controls under each title: "Place hold", "Add tag", "Add to cart" etc. - The colors should be consistent, with a slightly darker blue for the icons. - Scroll down until the table header "sticks" to the top of the viewport. - There should be no gap between the header row with the pagination links and the row with the "Select all", "Clear all", etc. controls. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Picked from QA queue, reviewed and tested.
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12