Bug 36422

Summary: Triggered holds should not display information about transferring because the item is in a rotating collection.
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Hold requestsAssignee: Lucas Gass (lukeg) <lucas>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: carthur, gmcharlt, heather
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 36422: Only show rotating collection transfer warning if there are no holds on an item

Description Lucas Gass (lukeg) 2024-03-25 20:29:17 UTC
To recreate:
1. Tools > Rotating collections
2. Set up a rotating collection from Branch A and transfer it to Branch B.
3. From Branch A put a hold on that same item for pickup a Branch A.
4. Check the item in to trigger the hold at Branch A. 
5. Notice the modal says that the item is on hold and waiting correctly at Branch A. 
6. The modal also says "Please transfer item to: Branch 2. This is part of a rotating collection".


The warning about transferring because its in a rotating collection should not show here, it's confusing. It should only show when the hold is canceled or after it has been checked back in.
Comment 1 Lucas Gass (lukeg) 2024-03-25 20:49:31 UTC
Created attachment 163877 [details] [review]
Bug 36422: Only show rotating collection transfer warning if there are no holds on an item

To Test:
1. Tools > Rotating collections
2. Set up a rotating collection from Branch A and transfer it to Branch B.
3. From Branch A put a hold on that same item for pickup a Branch A.
4. Check the item in to trigger the hold at Branch A.
5. Notice the modal says that the item is on hold and waiting correctly at Branch A.
6. The modal also says "Please transfer item to: Branch 2. This is part of a rotating collection".
7. APPLY PATCH
8. Try steps 3 - 5 again. This time there should be no info. about needing to transfer the item for the rotating collection.
Comment 2 Heather Rommens 2024-03-25 21:35:11 UTC
Followed the testing plan, but when the waiting hold on the item was cancelled, a transfer was not initiated for the item to return to its current location for the rotating collection. A message displayed for the slip to be printed, but no transfer or cancel transfer options.
Comment 3 Heather Rommens 2024-04-20 19:34:00 UTC
Separate bug filed regarding the failure to initiate transfer of items in a rotating collection. See bug 36658.