Bug 36422 - Triggered holds should not display information about transferring because the item is in a rotating collection.
Summary: Triggered holds should not display information about transferring because the...
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-25 20:29 UTC by Lucas Gass (lukeg)
Modified: 2024-04-20 19:34 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 36422: Only show rotating collection transfer warning if there are no holds on an item (1.54 KB, patch)
2024-03-25 20:49 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-03-25 20:29:17 UTC
To recreate:
1. Tools > Rotating collections
2. Set up a rotating collection from Branch A and transfer it to Branch B.
3. From Branch A put a hold on that same item for pickup a Branch A.
4. Check the item in to trigger the hold at Branch A. 
5. Notice the modal says that the item is on hold and waiting correctly at Branch A. 
6. The modal also says "Please transfer item to: Branch 2. This is part of a rotating collection".


The warning about transferring because its in a rotating collection should not show here, it's confusing. It should only show when the hold is canceled or after it has been checked back in.
Comment 1 Lucas Gass (lukeg) 2024-03-25 20:49:31 UTC
Created attachment 163877 [details] [review]
Bug 36422: Only show rotating collection transfer warning if there are no holds on an item

To Test:
1. Tools > Rotating collections
2. Set up a rotating collection from Branch A and transfer it to Branch B.
3. From Branch A put a hold on that same item for pickup a Branch A.
4. Check the item in to trigger the hold at Branch A.
5. Notice the modal says that the item is on hold and waiting correctly at Branch A.
6. The modal also says "Please transfer item to: Branch 2. This is part of a rotating collection".
7. APPLY PATCH
8. Try steps 3 - 5 again. This time there should be no info. about needing to transfer the item for the rotating collection.
Comment 2 Heather Rommens 2024-03-25 21:35:11 UTC
Followed the testing plan, but when the waiting hold on the item was cancelled, a transfer was not initiated for the item to return to its current location for the rotating collection. A message displayed for the slip to be printed, but no transfer or cancel transfer options.
Comment 3 Heather Rommens 2024-04-20 19:34:00 UTC
Separate bug filed regarding the failure to initiate transfer of items in a rotating collection. See bug 36658.