Bug 36452

Summary: Patron message does not respect multiple line display
Product: Koha Reporter: Philip Orr <philip.orr>
Component: PatronsAssignee: Philip Orr <philip.orr>
Status: Pushed to oldstable --- QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, gmcharlt, kyle.m.hall, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12
Circulation function:
Attachments: Bug 36452: correct display of patron message
Bug 36452: correct display of patron message
Bug 36452: correct display of patron message

Description Philip Orr 2024-03-28 10:29:46 UTC
If you add a message (for the staff interface) that contains
multiple lines to a patron, it will be displayed as a single
line in the staff interface.
For instance the following:
"Test1
Test2
Test3"
Will be displayed as "Test1 Test2 Test3" in the staff interface.
Multi-line messages for the OPAC are displayed correctly
in the OPAC as multiple lines. The problem also doesn't seem to
affect the patron notes - those are displayed correctly. Only
the patron messages.
Comment 1 Philip Orr 2024-03-28 10:41:49 UTC
Created attachment 164041 [details] [review]
Bug 36452: correct display of patron message

To test:
1. Before applying the patch:
2. In the staff interface, navigate to a patron
3. Add a new staff message that contains multiple lines (e.g. using enter for the next line)
4. Save the message and check the display.
It will be a single line.
5. Apply the patch and navigate back to the
patron
6. The message should now be displayed as multiple lines.
Comment 2 Philip Orr 2024-03-28 10:48:21 UTC
Credit to joubu for writing the patch, by the way!
Comment 3 Owen Leonard 2024-03-28 11:24:01 UTC
Created attachment 164049 [details] [review]
Bug 36452: correct display of patron message

To test:
1. Before applying the patch:
2. In the staff interface, navigate to a patron
3. Add a new staff message that contains multiple lines (e.g. using
   enter for the next line)
4. Save the message and check the display.
   It will be a single line.
5. Apply the patch and navigate back to the
   patron
6. The message should now be displayed as multiple lines.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Nick Clemens (kidclamp) 2024-04-01 17:19:26 UTC
Created attachment 164216 [details] [review]
Bug 36452: correct display of patron message

To test:
1. Before applying the patch:
2. In the staff interface, navigate to a patron
3. Add a new staff message that contains multiple lines (e.g. using
   enter for the next line)
4. Save the message and check the display.
   It will be a single line.
5. Apply the patch and navigate back to the
   patron
6. The message should now be displayed as multiple lines.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Katrin Fischer 2024-04-05 09:53:13 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-23 11:56:29 UTC
Pushed to 23.11.x for 23.11.06
Comment 7 Lucas Gass 2024-05-28 17:30:54 UTC
Backported to 23.05.x for upcoming 23.05.12