If you add a message (for the staff interface) that contains multiple lines to a patron, it will be displayed as a single line in the staff interface. For instance the following: "Test1 Test2 Test3" Will be displayed as "Test1 Test2 Test3" in the staff interface. Multi-line messages for the OPAC are displayed correctly in the OPAC as multiple lines. The problem also doesn't seem to affect the patron notes - those are displayed correctly. Only the patron messages.
Created attachment 164041 [details] [review] Bug 36452: correct display of patron message To test: 1. Before applying the patch: 2. In the staff interface, navigate to a patron 3. Add a new staff message that contains multiple lines (e.g. using enter for the next line) 4. Save the message and check the display. It will be a single line. 5. Apply the patch and navigate back to the patron 6. The message should now be displayed as multiple lines.
Credit to joubu for writing the patch, by the way!
Created attachment 164049 [details] [review] Bug 36452: correct display of patron message To test: 1. Before applying the patch: 2. In the staff interface, navigate to a patron 3. Add a new staff message that contains multiple lines (e.g. using enter for the next line) 4. Save the message and check the display. It will be a single line. 5. Apply the patch and navigate back to the patron 6. The message should now be displayed as multiple lines. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 164216 [details] [review] Bug 36452: correct display of patron message To test: 1. Before applying the patch: 2. In the staff interface, navigate to a patron 3. Add a new staff message that contains multiple lines (e.g. using enter for the next line) 4. Save the message and check the display. It will be a single line. 5. Apply the patch and navigate back to the patron 6. The message should now be displayed as multiple lines. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12