Bug 36490

Summary: Correct tab-switching keyboard shortcut for header search forms
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Pushed to main --- QA Contact: Martin Renvoize <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: andrewfh, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Bug Depends on: 35850    
Bug Blocks:    
Attachments: Bug 36490: Correct tab-switching keyboard shortcut for header search forms
Bug 36490: Correct tab-switching keyboard shortcut for header search forms
Bug 36490: Correct tab-switching keyboard shortcut for header search forms
Bug 36490: Correct tab-switching keyboard shortcut for header search forms

Description Owen Leonard 2024-04-02 12:39:07 UTC
Bug 35850 changed the markup of the header search forms but didn't update the JS in staff-global.js to match those changes.
Comment 1 Owen Leonard 2024-04-02 12:52:16 UTC
Created attachment 164265 [details] [review]
Bug 36490: Correct tab-switching keyboard shortcut for header search forms

This patch updates staff-global.js so that we correctly define the
keyboard shortcuts for search header tabs following the switch to using
the WRAPPER for tabs in Bug 35850.

To test, apply the patch clear your browser cache if necessary.

- Go to the staff interface.
- Test each keyboard shortcut to confirm that the header search tabs
  activate correctly:
  - Check in: Alt-r
  - Renew: Alt-w
  - Search: Alt-q
  - Check out: Alt-u
- Test that the keyboard shortcut takes you to the correct page if the
  header search form doesn't exist on the page, e.g. the Authorities
  home page.
Comment 2 Andrew Fuerste-Henry 2024-04-02 13:28:44 UTC
This works except for one small thing. The alt-u shortcut for checkout only works if my cursor is not in the search box. If my cursor is in the search box and waiting for me to type, alt-u inputs a "ยจ". If my cursor if not in the box, alt-u correctly takes me to checkout.

Otherwise all of these work, regardless of where my cursor is.
I'm on a Mac, if that matters. So I was pressing Option instead of Alt.
Comment 3 Owen Leonard 2024-04-02 14:23:58 UTC
(In reply to Andrew Fuerste-Henry from comment #2)
> This works except for one small thing. The alt-u shortcut for checkout only
> works if my cursor is not in the search box.

I think this is the same as before the patch. Could you check in a pre-Bug 35850 installation, e.g. https://intranet.bywatersolutions.com/ ?
Comment 4 Andrew Fuerste-Henry 2024-04-02 18:55:41 UTC
Created attachment 164300 [details] [review]
Bug 36490: Correct tab-switching keyboard shortcut for header search forms

This patch updates staff-global.js so that we correctly define the
keyboard shortcuts for search header tabs following the switch to using
the WRAPPER for tabs in Bug 35850.

To test, apply the patch clear your browser cache if necessary.

- Go to the staff interface.
- Test each keyboard shortcut to confirm that the header search tabs
  activate correctly:
  - Check in: Alt-r
  - Renew: Alt-w
  - Search: Alt-q
  - Check out: Alt-u
- Test that the keyboard shortcut takes you to the correct page if the
  header search form doesn't exist on the page, e.g. the Authorities
  home page.

Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Comment 5 Andrew Fuerste-Henry 2024-04-02 18:58:35 UTC
(In reply to Owen Leonard from comment #3)
> (In reply to Andrew Fuerste-Henry from comment #2)
> > This works except for one small thing. The alt-u shortcut for checkout only
> > works if my cursor is not in the search box.
> 
> I think this is the same as before the patch. Could you check in a pre-Bug
> 35850 installation, e.g. https://intranet.bywatersolutions.com/ ?

Confirmed this issue exists before your patch when using Chrome on Mac. As such, I've signed off.
Comment 6 Martin Renvoize 2024-04-17 12:50:01 UTC
Sorry Owen, this one no longer applies.
Comment 7 Owen Leonard 2024-04-17 13:00:39 UTC
Created attachment 165008 [details] [review]
Bug 36490: Correct tab-switching keyboard shortcut for header search forms

This patch updates staff-global.js so that we correctly define the
keyboard shortcuts for search header tabs following the switch to using
the WRAPPER for tabs in Bug 35850.

To test, apply the patch clear your browser cache if necessary.

- Go to the staff interface.
- Test each keyboard shortcut to confirm that the header search tabs
  activate correctly:
  - Check in: Alt-r
  - Renew: Alt-w
  - Search: Alt-q
  - Check out: Alt-u
- Test that the keyboard shortcut takes you to the correct page if the
  header search form doesn't exist on the page, e.g. the Authorities
  home page.

Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Comment 8 Martin Renvoize 2024-04-17 15:51:52 UTC
Created attachment 165024 [details] [review]
Bug 36490: Correct tab-switching keyboard shortcut for header search forms

This patch updates staff-global.js so that we correctly define the
keyboard shortcuts for search header tabs following the switch to using
the WRAPPER for tabs in Bug 35850.

To test, apply the patch clear your browser cache if necessary.

- Go to the staff interface.
- Test each keyboard shortcut to confirm that the header search tabs
  activate correctly:
  - Check in: Alt-r
  - Renew: Alt-w
  - Search: Alt-q
  - Check out: Alt-u
- Test that the keyboard shortcut takes you to the correct page if the
  header search form doesn't exist on the page, e.g. the Authorities
  home page.

Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2024-04-17 15:52:10 UTC
All working nicely, thanks Owen.
Comment 10 Katrin Fischer 2024-04-18 14:52:10 UTC
Pushed for 24.05!

Well done everyone, thank you!