|
Description
Alex Buckley
2024-04-04 03:41:25 UTC
Created attachment 164575 [details] [review] Bug 36515: Amend MARC modification templates so control fields can be copied to subfields Test plan: 1. Apply patch and restart services 2. Create a MARC modification template to move 001 to 099$a 3. Perform a Batch record modification using your MARC modification template from #1 4. Confirm that the template has successfully moved the 001 control field value to the 099$a subfield Sponsored-by: Education Services Australia SCIS Created attachment 165924 [details] [review] Bug 36515: Amend MARC modification templates so control fields can be copied to subfields Test plan: 1. Apply patch and restart services 2. Create a MARC modification template with the action: Copy and replace field 001 to 099$a unless 099$a exists 3. Perform a Batch record modification using your MARC modification template from #2 4. Confirm that the template has successfully moved the 001 control field value to the 099$a subfield Sponsored-by: Education Services Australia SCIS Created attachment 165928 [details] [review] Bug 36515: Amend MARC modification templates so control fields can be copied to subfields Test plan: 1. Apply patch and restart services 2. Create a MARC modification template with the action: Copy and replace field 001 to 099$a unless 099$a exists 3. Perform a Batch record modification using your MARC modification template from #2 4. Confirm that the template has successfully moved the 001 control field value to the 099$a subfield Sponsored-by: Education Services Australia SCIS Created attachment 165929 [details] [review] Bug 36515: Add unit tests Test plan: 1. Run unit tests ktd --shell prove t/SimpleMARC.t Sponsored-by: Education Services Australia SCIS Ready for testing. Created attachment 166026 [details] [review] Bug 36515: Amend MARC modification templates so control fields can be copied to subfields Test plan: 1. Apply patch and restart services 2. Create a MARC modification template with the action: Copy and replace field 001 to 099$a unless 099$a exists 3. Perform a Batch record modification using your MARC modification template from #2 4. Confirm that the template has successfully moved the 001 control field value to the 099$a subfield Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david@davidnind.com> Created attachment 166027 [details] [review] Bug 36515: Add unit tests Test plan: 1. Run unit tests ktd --shell prove t/SimpleMARC.t Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david@davidnind.com> Thanks for testing David! Created attachment 169215 [details] [review] Bug 36515: Add unit tests Test plan: 1. Run unit tests ktd --shell prove t/SimpleMARC.t Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 169216 [details] [review] Bug 36515: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> It looks like something happened here and one of the patches was obsoleted. Trying to fix. Pushed for 24.11! Well done everyone, thank you! Enhancement will not be included in 24.05.x |