|
Description
Michaela Sieber
2024-04-10 07:52:43 UTC
Created attachment 164595 [details] [review] Bug 36563: Dirty fix Created attachment 164596 [details] [review] Bug 36563: Dirty fix Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> 'is not' searches dont appear to be working either (In reply to Lucas Gass from comment #3) > 'is not' searches dont appear to be working either Should we fix that here or separately? (In reply to Katrin Fischer from comment #4) > (In reply to Lucas Gass from comment #3) > > 'is not' searches dont appear to be working either > > Should we fix that here or separately? I filed Bug 36571 Created attachment 164673 [details] [review] Bug 36563: Turn into array only if required Test plan, apply first patch: 1- Visit item search: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl 2- Set "Home library" -> "is not" -> "Centerville". Notice you get items from Centerville. 3- Apply second patch, repeat step 2, notice you now don't get items from Centervile. Created attachment 164675 [details] [review] Bug 36563: Dirty fix Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 164676 [details] [review] Bug 36563: Turn into array only if required Test plan, apply first patch: 1- Visit item search: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl 2- Set "Home library" -> "is not" -> "Centerville". Notice you get items from Centerville. 3- Apply second patch, repeat step 2, notice you now don't get items from Centervile. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 164677 [details] [review] Bug 36563: Turn into array only if required Test plan, apply first patch: 1- Visit item search: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl 2- Set "Home library" -> "is not" -> "Centerville". Notice you get items from Centerville. 3- Apply second patch, repeat step 2, notice you now don't get items from Centervile. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> This now only works if you are selecting multiple parameters. If you choose only 1 the search doesn't work. Created attachment 164756 [details] [review] Bug 36563: Turn into array only if required Test plan, apply first patch: 1- Visit item search: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl 2- Set "Home library" -> "is not" -> "Centerville". Notice you get items from Centerville. 3- Apply second patch, repeat step 2, notice you now don't get items from Centervile. 4- Test other use cases, like 'is' and 'is not' for multiple choices (In reply to Lucas Gass from comment #10) > This now only works if you are selecting multiple parameters. If you choose > only 1 the search doesn't work. Thank you Lucas, I've resubmitted a new version of the patch. Can you please try and test again? Thanks! I tried something more pretty like: my @q = $cgi->param( $p . "[]" ) // $cgi->param( $p ); But I failed. For some reason that doesn't work. Created attachment 164857 [details] [review] Bug 36563: Turn into array only if required Test plan, apply first patch: 1- Visit item search: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl 2- Set "Home library" -> "is not" -> "Centerville". Notice you get items from Centerville. 3- Apply second patch, repeat step 2, notice you now don't get items from Centervile. 4- Test other use cases, like 'is' and 'is not' for multiple choices Signed-off-by: Owen Leonard <oleonard@myacpl.org> Thanks Pedro. This seems to be working well now with is/is not operators. Scripts are happy, passing QA. Created attachment 165141 [details] [review] Bug 36563: Turn into array only if required Test plan, apply first patch: 1- Visit item search: http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl 2- Set "Home library" -> "is not" -> "Centerville". Notice you get items from Centerville. 3- Apply second patch, repeat step 2, notice you now don't get items from Centervile. 4- Test other use cases, like 'is' and 'is not' for multiple choices Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! Noting I see the keywords already to get this into 23.11 and 23.05 ... and we will be very happy about it :) +Aleisha -- we use this daily for database maintenance Could this please be backported ? Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 |