| Summary: | Changing rows per page on a custom report is broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Component: | Reports | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | dcook, fridolin.somers |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 34478 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 36568: Fix id parameter in template
Bug 36568: Fix id parameter in template Bug 36568: Fix id parameter in template |
||
|
Description
Emily Lamancusa (emlam)
2024-04-10 16:51:36 UTC
Created attachment 164629 [details] [review] Bug 36568: Fix id parameter in template Fix missed case of changing parameter name from "reports" to "id" To test: 1. Find or create an SQL report that will return more than 20 rows 2. Run the report 3. Change the "Rows per page" drop-down to a new value --> An empty page is displayed! 4. Apply patch 5. Repeat steps 2-3 --> The report is displayed with the appropriate number of results Created attachment 164641 [details] [review] Bug 36568: Fix id parameter in template Fix missed case of changing parameter name from "reports" to "id" To test: 1. Find or create an SQL report that will return more than 20 rows 2. Run the report 3. Change the "Rows per page" drop-down to a new value --> An empty page is displayed! 4. Apply patch 5. Repeat steps 2-3 --> The report is displayed with the appropriate number of results Signed-off-by: David Cook <dcook@prosentient.com.au> Nice one. Small but important change. Created attachment 164774 [details] [review] Bug 36568: Fix id parameter in template Fix missed case of changing parameter name from "reports" to "id" To test: 1. Find or create an SQL report that will return more than 20 rows 2. Run the report 3. Change the "Rows per page" drop-down to a new value --> An empty page is displayed! 4. Apply patch 5. Repeat steps 2-3 --> The report is displayed with the appropriate number of results Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed for 24.05! Well done everyone, thank you! |