36568 – Changing rows per page on a custom report is broken

Bug 36568 - Changing rows per page on a custom report is broken

Summary: Changing rows per page on a custom report is broken

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Reports (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low major
Assignee:	Emily Lamancusa (emlam)
QA Contact:	Testopia

URL:
Keywords:

Depends on:	34478
Blocks:
	Show dependency tree / graph

Reported:	2024-04-10 16:51 UTC by Emily Lamancusa (emlam)
Modified:	2024-12-23 08:06 UTC (History)
CC List:	2 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:	24.05.00
Circulation function:

Attachments
Bug 36568: Fix id parameter in template (1.66 KB, patch) 2024-04-10 17:00 UTC, Emily Lamancusa (emlam)	Details \| Diff \| Splinter Review
Bug 36568: Fix id parameter in template (1.72 KB, patch) 2024-04-11 00:50 UTC, David Cook	Details \| Diff \| Splinter Review
Bug 36568: Fix id parameter in template (1.77 KB, patch) 2024-04-11 15:35 UTC, Nick Clemens (kidclamp)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Emily Lamancusa (emlam) 2024-04-10 16:51:36 UTC

Comment 1 Emily Lamancusa (emlam) 2024-04-10 17:00:23 UTC

Created attachment 164629 [details] [review]
Bug 36568: Fix id parameter in template

Fix missed case of changing parameter name from "reports" to "id"

To test:
1. Find or create an SQL report that will return more than 20 rows
2. Run the report
3. Change the "Rows per page" drop-down to a new value
--> An empty page is displayed!
4. Apply patch
5. Repeat steps 2-3
--> The report is displayed with the appropriate number of results

Comment 2 David Cook 2024-04-11 00:50:52 UTC

Created attachment 164641 [details] [review]
Bug 36568: Fix id parameter in template

Fix missed case of changing parameter name from "reports" to "id"

To test:
1. Find or create an SQL report that will return more than 20 rows
2. Run the report
3. Change the "Rows per page" drop-down to a new value
--> An empty page is displayed!
4. Apply patch
5. Repeat steps 2-3
--> The report is displayed with the appropriate number of results

Signed-off-by: David Cook <dcook@prosentient.com.au>

Comment 3 David Cook 2024-04-11 00:51:11 UTC

Nice one. Small but important change.

Comment 4 Nick Clemens (kidclamp) 2024-04-11 15:35:40 UTC

Created attachment 164774 [details] [review]
Bug 36568: Fix id parameter in template

Fix missed case of changing parameter name from "reports" to "id"

To test:
1. Find or create an SQL report that will return more than 20 rows
2. Run the report
3. Change the "Rows per page" drop-down to a new value
--> An empty page is displayed!
4. Apply patch
5. Repeat steps 2-3
--> The report is displayed with the appropriate number of results

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Comment 5 Katrin Fischer 2024-04-12 09:28:29 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 6 Fridolin Somers 2024-04-17 08:51:06 UTC

Depends on Bug 34478 not in 23.11.x