Bug 36571

Summary: Item search is broken when using 'is not' for searching
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: CLOSED INVALID QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: clemens.tubach, gmcharlt, kyle.m.hall, pedro.amorim
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Lucas Gass (lukeg) 2024-04-11 07:53:23 UTC
To recreate:

1. Go to item search.
2. Select multiple parameters and choose 'is not'
3. The search does not return items correctly.
Comment 1 Pedro Amorim 2024-04-11 09:49:31 UTC
Hey guys, testing this. The issue is introduced by the current patch from bug 36563 i.e. I can't reproduce the issue in current master.

To reproduce:
1- Before applying bug 36563, visit item search:
http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl
2- Set "Home library" -> "is not" -> "Centerville". Notice you don't get items from Centerville.
3- Apply patch from bug 36563, repeat step 2, notice you now get items from Centervile.

The fix for this should, I believe, be part of bug 36563 patchset. Or at the very least this bug should depend on bug 36563.
Comment 2 Clemens Tubach 2024-04-11 12:21:27 UTC
I tested it, the issue doesn't occur in current master.
Comment 3 Lucas Gass (lukeg) 2024-04-11 12:24:49 UTC
Sorry, as Pedro said, this issue is in the patch for 36563, not in master. 

Marking RESOLVED - INVALID