Bug 36577

Summary: (bug 34478 follow-up) marc21_linking_section.pl not working
Product: Koha Reporter: Janusz Kaczmarek <januszop>
Component: Staff interfaceAssignee: Janusz Kaczmarek <januszop>
Status: CLOSED FIXED QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: major    
Priority: P1 - high CC: fridolin.somers, gmcharlt, jonathan.druart, martin.renvoize, victor
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:
Bug Depends on: 34478    
Bug Blocks:    
Attachments: Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working
Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working
Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working
Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working

Description Janusz Kaczmarek 2024-04-11 12:31:48 UTC
After applying "Bug 34478: op =~ ^cud- everywhere" the plugin marc21_linking_section.pl stopped working properly.  Changes in marc21_linking_section.tt need to be reflected in marc21_linking_section.pl
Comment 1 Janusz Kaczmarek 2024-04-11 12:44:16 UTC
Created attachment 164683 [details] [review]
Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working

After applying "Bug 34478: op =~ ^cud- everywhere" the plugin
marc21_linking_section.pl stopped working properly.  Changes
in marc21_linking_section.tt need to be reflected in marc21_linking_section.pl

Test plan
=========
1. Configure a MARC bibliographic framework to use the plugin
   marc21_linking_section.pl (e.g. in 773 $t).
2. Start creating a new record and go to 773 $t. Activate the plugin to find
   the host record (perform a search for any common word).
3. You will get no results.
4. Apply the patch, restart plack etc.
5. Repeat p. 2 - you should now see some results.

BTW, QA people - maybe it would pay to remove the commented code present there
since the very beginning (2012).
Comment 2 Janusz Kaczmarek 2024-04-12 20:15:20 UTC
Created attachment 164864 [details] [review]
Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working

After applying "Bug 34478: op =~ ^cud- everywhere" the plugin
marc21_linking_section.pl stopped working properly.  Since the plugin
does not perform a CUD operation, the GET request can be used, and so
the use of CSRF token is not needed.

The patch fixes also problems with result page numbers display.

Test plan
=========
1. Configure a MARC bibliographic framework to use the plugin
   marc21_linking_section.pl (e.g. in 773 $t).
2. Start creating a new record and go to 773 $t. Activate the plugin to find
   the any record to become the host record (perform a search for any
   common word, like 'and').
3. You will get no results.
4. Apply the patch, restart plack etc.
5. Repeat p. 2 - you should now see some results, possibly more than one
   page.  You should be able to change page with Next/Previous arrows and
   also with the page numbers.

BTW, QA people - maybe it would pay to remove the commented code present there
since the very beginning (2012).
Comment 3 Roman Dolny 2024-04-13 15:36:18 UTC
Created attachment 164867 [details] [review]
Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working

After applying "Bug 34478: op =~ ^cud- everywhere" the plugin
marc21_linking_section.pl stopped working properly.  Since the plugin
does not perform a CUD operation, the GET request can be used, and so
the use of CSRF token is not needed.

The patch fixes also problems with result page numbers display.

Test plan
=========
1. Configure a MARC bibliographic framework to use the plugin
   marc21_linking_section.pl (e.g. in 773 $t).
2. Start creating a new record and go to 773 $t. Activate the plugin to find
   the any record to become the host record (perform a search for any
   common word, like 'and').
3. You will get no results.
4. Apply the patch, restart plack etc.
5. Repeat p. 2 - you should now see some results, possibly more than one
   page.  You should be able to change page with Next/Previous arrows and
   also with the page numbers.

BTW, QA people - maybe it would pay to remove the commented code present there
since the very beginning (2012).

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 4 Martin Renvoize (ashimema) 2024-04-17 15:56:04 UTC
Created attachment 165026 [details] [review]
Bug 36577: (bug 34478 follow-up) marc21_linking_section.pl not working

After applying "Bug 34478: op =~ ^cud- everywhere" the plugin
marc21_linking_section.pl stopped working properly.  Since the plugin
does not perform a CUD operation, the GET request can be used, and so
the use of CSRF token is not needed.

The patch fixes also problems with result page numbers display.

Test plan
=========
1. Configure a MARC bibliographic framework to use the plugin
   marc21_linking_section.pl (e.g. in 773 $t).
2. Start creating a new record and go to 773 $t. Activate the plugin to find
   the any record to become the host record (perform a search for any
   common word, like 'and').
3. You will get no results.
4. Apply the patch, restart plack etc.
5. Repeat p. 2 - you should now see some results, possibly more than one
   page.  You should be able to change page with Next/Previous arrows and
   also with the page numbers.

BTW, QA people - maybe it would pay to remove the commented code present there
since the very beginning (2012).

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-04-18 14:52:13 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-22 12:20:33 UTC
Depends on Bug 34478 not in 23.11.x