Since CSRF procetion form without CUD action must use GET instead of POST Fix value_builder/unimarc_field_4XX.pl
Like Bug 36577 for MARC21
Created attachment 183791 [details] [review] Bug 40306: Use GET in form of value_builder/unimarc_field_4XX.pl Since CSRF procetion form without CUD action must use GET instead of POST Fix value_builder/unimarc_field_4XX.pl Test plan: 1) Use UNIMARC DB 2) Be sure value builder unimarc_field_4XX.pl is defined on 461$t 3) Create a new biblio record 4) On 461$t click on 'Tag editor' icon 5) Perform a search 6) Click on choose 7) Field 461 is filled
Created attachment 183804 [details] [review] Bug 40306: Use GET in form of value_builder/unimarc_field_4XX.pl Since CSRF procetion form without CUD action must use GET instead of POST Fix value_builder/unimarc_field_4XX.pl Test plan: 1) Use UNIMARC DB 2) Be sure value builder unimarc_field_4XX.pl is defined on 461$t 3) Create a new biblio record 4) On 461$t click on 'Tag editor' icon 5) Perform a search 6) Click on choose 7) Field 461 is filled Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Startup KTD with UNIMARTC: Edit your .env file and set KOHA_MARC_FLAVOUR=unimarc 2. For the default framework, the value builder unimarc_field_4XX.pl is already configured for 461$t. 3. Create a new bibliographic record. 4. For 461$t, click the 'Tag editor'. 5. Search for something, for example: a 6. Click 'Start search' - nothing happens. 7. Apply the patch. 8. Refresh the editor and repeat steps 4 and 5. 9. The 'Start search' button now works.
Looks like number.startfrom is wrong too ?
(In reply to Marcel de Rooy from comment #5) > Looks like number.startfrom is wrong too ? Ah there are 2 vars startfrom : my $startfrom = $query->param('startfrom'); And : push @numbers, { number => $i, highlight => $highlight, searchdata => \@field_data, startfrom => ( $i - 1 ) }; In this case number.startfrom is correct. You can look at "marc21_linking_section.tt" that is nearly the same code.