| Summary: | Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Janusz Kaczmarek <januszop> |
| Component: | Searching - Elasticsearch | Assignee: | Janusz Kaczmarek <januszop> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/896 |
| Text to go in the release notes: |
This extends the Elasticsearch default search field mappings to include 752 (MARC21) and 210a, 214a (UNIMARC) in the index for place of publication.
|
Version(s) released in: |
24.05.00
|
| Circulation function: | |||
| Bug Depends on: | 36269 | ||
| Bug Blocks: | 37319 | ||
| Attachments: |
Bug 36578: Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC
Bug 36578: Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC Bug 36578: Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC |
||
|
Description
Janusz Kaczmarek
2024-04-11 14:20:32 UTC
Extension to bug 36269: 1) when cataloguing old prints, the standardized form of the place of publication is given in the field 752 and as such should also be indexed. 2) Also, normal UNIMARC fields for publication place should be indexed (210a, 214a). Created attachment 164757 [details] [review] Bug 36578: Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC Extension to bug 36269: 1) when cataloguing old prints, the standardized form of the place of publication is given in the field 752 and as such should also be indexed. 2) Also, normal UNIMARC fields for publication place should be indexed (210a, 214a). Created attachment 164780 [details] [review] Bug 36578: Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC Extension to bug 36269: 1) when cataloguing old prints, the standardized form of the place of publication is given in the field 752 and as such should also be indexed. 2) Also, normal UNIMARC fields for publication place should be indexed (210a, 214a). Test plan ========= Scenario A (MARC 21, field 752) ------------------------------- 0. Have an installation with Elasticsearch and MARC 21 configuration. 1. Activate subfields 752 $a, $d in the default framework (Visibility: Editor). 2. Edit an existing record with this framework, putting some rare words in the 752 $a and $d subfields. 3. Try to make a search with tis words (general keyword or by publication place, i.e. pl:). 4. You hsold get no results. 5. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 6. Repeat p. 3. You should get your edited record. Scenario B (UNIMARC) -------------------- 0. Have an installation with Elasticsearch and UNIMARC configuration. 1. Try to search for a publication place, either with pl: directly in the search window, or in Advanced search, with Publisher location. With ktd UNIMARC test date you can search for 'Ste Geneviève Cedex'. 2. You should get no results. 3. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 4. Repeat p. 1. You should get some results (with ktd test data set and Ste Geneviève Cedex - record #1). Created attachment 165146 [details] [review] Bug 36578: Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC Extension to bug 36269: 1) when cataloguing old prints, the standardized form of the place of publication is given in the field 752 and as such should also be indexed. 2) Also, normal UNIMARC fields for publication place should be indexed (210a, 214a). Test plan ========= Scenario A (MARC 21, field 752) ------------------------------- 0. Have an installation with Elasticsearch and MARC 21 configuration. 1. Activate subfields 752 $a, $d in the default framework (Visibility: Editor). 2. Edit an existing record with this framework, putting some rare words in the 752 $a and $d subfields. 3. Try to make a search with tis words (general keyword or by publication place, i.e. pl:). 4. You hsold get no results. 5. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 6. Repeat p. 3. You should get your edited record. Scenario B (UNIMARC) -------------------- 0. Have an installation with Elasticsearch and UNIMARC configuration. 1. Try to search for a publication place, either with pl: directly in the search window, or in Advanced search, with Publisher location. With ktd UNIMARC test date you can search for 'Ste Geneviève Cedex'. 2. You should get no results. 3. Apply the patch, reindex with: sudo koha-elasticsearch --rebuild -r -b kohadev 4. Repeat p. 1. You should get some results (with ktd test data set and Ste Geneviève Cedex - record #1). Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Grabbing this simple one out of the QA queue. Pushed for 24.05! Well done everyone, thank you! Not backported to 23.11.x I don't know if it was changed after by another commit or something, but the fields are now in the "other-control-number" index.
other-control-number:
label: other-control-number
mandatory: ~
mappings:
- facet: ''
marc_field: '035'
marc_type: marc21
sort: 1
suggestible: ''
- facet: ''
marc_field: 752ad
marc_type: marc21
sort: 1
suggestible: ''
- facet: ''
marc_field: 210a
marc_type: unimarc
sort: 1
suggestible: ''
- facet: ''
marc_field: 214a
marc_type: unimarc
sort: 1
suggestible: ''
opac: 1
staff_client: 1
type: ''
https://git.koha-community.org/Koha-community/Koha/src/branch/main/admin/searchengine/elasticsearch/mappings.yaml#L3170
This could be a merge issue :( Would you mind filing a separate bug? (In reply to Katrin Fischer from comment #9) > This could be a merge issue :( Would you mind filing a separate bug? Already done: Bug 37319 - Move mappings for 752ad (MARC21) and 210a/214a (UNIMARC) to pl index Thanks! I added them to the manual anyway, even if it will only be true once bug 37319 passes. |